From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCZUB-0006FJ-DN for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 09:29:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCZUA-0006Er-1c for grub-devel@gnu.org; Fri, 05 Jun 2009 09:29:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCZU4-0006Ef-JM for grub-devel@gnu.org; Fri, 05 Jun 2009 09:29:28 -0400 Received: from [199.232.76.173] (port=40377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCZU4-0006Eb-9p for grub-devel@gnu.org; Fri, 05 Jun 2009 09:29:24 -0400 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]:4444) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCZU3-0001mV-UL for grub-devel@gnu.org; Fri, 05 Jun 2009 09:29:24 -0400 Received: from marco (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id n55DTMG9085170 for ; Fri, 5 Jun 2009 15:29:22 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1243426603.3425.2.camel@fz.local> <1243865933.3417.2.camel@fz.local> <1244043954.3407.4.camel@fz.local> <874ouwcst9.fsf@xs4all.nl> <1244191623.3416.1.camel@fz.local> <874ouvxao0.fsf@xs4all.nl> <1244197962.3416.13.camel@fz.local> <87zlcmx3ws.fsf@xs4all.nl> <1244207062.3416.45.camel@fz.local> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 05 Jun 2009 15:29:21 +0200 In-Reply-To: <1244207062.3416.45.camel@fz.local> (Felix Zielcke's message of "Fri, 05 Jun 2009 15:04:22 +0200") Message-ID: <87vdnax0zy.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] add true and false commands X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 13:29:30 -0000 Felix Zielcke writes: > Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: > >> > So what should I do now? >> > Placing it in normal.mod or minicmd.mod where it's included in rescue >> > mode or placing it into a true.mod where the size increase would be >> > bigger? >> >> minicmd.mod is not a very descriptive name. Better call is >> truefalse.mod or something like that. > > minicmd.mod already exists, see commands/minicmd.c (or my first patch). > That's where I put it in the first patch. > Anyway here's a new one which adds true.mod which gets 1264 bytes big. Oh, I didn't know minicmd.mod. Is it useful to have one instead of a few separate modules? Space of these smaller modules is not really a concern to me. -- Marco