From: Kevin Hilman <khilman@deeprootsystems.com>
To: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Cc: linux-omap@vger.kernel.org, jouni.hogander@nokia.com
Subject: Re: [PATCH 1/1] ARM:OMAP3: Fix PLL_MOD CLKEN offset in scratchpad
Date: Thu, 14 May 2009 10:11:46 -0700 [thread overview]
Message-ID: <87vdo3txrh.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1242126136-8419-2-git-send-email-kalle.jokiniemi@digia.com> (Kalle Jokiniemi's message of "Tue\, 12 May 2009 14\:02\:16 +0300")
Kalle Jokiniemi <kalle.jokiniemi@digia.com> writes:
> The CM_CLKEN_PLL register saved in scratchpad memory
> was wrongly using offset of 0x0004 instead of 0x0000.
>
> The effect of this was that boot ROM code would
> restore the wrong value when waking up from off mode.
> This wrong value, however, will be overwritten by
> prcm context restore. Still, a short period of wrong
> clock settings in CM_CLKEN_PLL remained between ROM
> code and prcm context restore. This is fixed by the
> patch.
>
> Problem reported by: Jouni Högander <jouni.hogander@nokia.com>
>
> Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Thanks, pushed to PM branch.
Kevin
> ---
> arch/arm/mach-omap2/control.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
> index a0429fe..60de860 100644
> --- a/arch/arm/mach-omap2/control.c
> +++ b/arch/arm/mach-omap2/control.c
> @@ -235,7 +235,7 @@ void omap3_save_scratchpad_contents(void)
> prcm_block_contents.cm_clksel_wkup =
> cm_read_mod_reg(WKUP_MOD, CM_CLKSEL);
> prcm_block_contents.cm_clken_pll =
> - cm_read_mod_reg(PLL_MOD, OMAP3430_CM_CLKEN_PLL);
> + cm_read_mod_reg(PLL_MOD, CM_CLKEN);
> prcm_block_contents.cm_autoidle_pll =
> cm_read_mod_reg(PLL_MOD, OMAP3430_CM_AUTOIDLE_PLL);
> prcm_block_contents.cm_clksel1_pll =
> --
> 1.5.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-05-14 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 11:02 [PATCH 0/1] ARM:OMAP3: Fix PLL_MOD CLKEN offset in scratchpad Kalle Jokiniemi
2009-05-12 11:02 ` [PATCH 1/1] " Kalle Jokiniemi
2009-05-14 17:11 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdo3txrh.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=jouni.hogander@nokia.com \
--cc=kalle.jokiniemi@digia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.