Re: [RFC PATCH v4 1/5] mac80211: enable IEEE80211_CONF_PS only when associated

[Kalle Valo <kalle.valo@nokia.com>]

Johannes Berg <johannes@sipsolutions.net> writes:

> On Tue, 2008-12-02 at 22:03 +0200, Kalle Valo wrote:
>
>> -	return ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS);
>> +	if (ps == local->powersave)
>> +		return ret;
>> +
>> +set:
>> +	local->powersave = ps;
>> +
>> +	if (sdata->vif.type != NL80211_IFTYPE_STATION)
>> +		return ret;
>
> Shouldn't that test be earlier? There's little sense in supporting PS if
> you have a non-STA interface. 

I'll move the test.

> In fact, it might make sense to check that there's no other
> interface (except monitor) open?

I'll add this check as well.

Thank you for the comments.

-- 
Kalle Valo