From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTWyD-0007QN-N3 for mharc-grub-devel@gnu.org; Thu, 14 Aug 2008 03:10:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTWyC-0007P6-0o for grub-devel@gnu.org; Thu, 14 Aug 2008 03:10:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTWy9-0007MY-CX for grub-devel@gnu.org; Thu, 14 Aug 2008 03:10:03 -0400 Received: from [199.232.76.173] (port=51602 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTWy9-0007MT-3K for grub-devel@gnu.org; Thu, 14 Aug 2008 03:10:01 -0400 Received: from mx20.gnu.org ([199.232.41.8]:23120) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTWy8-0003uB-JG for grub-devel@gnu.org; Thu, 14 Aug 2008 03:10:00 -0400 Received: from smtp-vbr3.xs4all.nl ([194.109.24.23]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTWy7-0006AX-T6 for grub-devel@gnu.org; Thu, 14 Aug 2008 03:10:00 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr3.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7E79wo4000214 for ; Thu, 14 Aug 2008 09:09:58 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1218558487.19045.8.camel@fz.local> <1218558734.19045.10.camel@fz.local> <87fxp9di59.fsf@xs4all.nl> <20080812224041.GB3141@thorin> <1218606980.4008.9.camel@fz.local> <87abfhb60p.fsf@xs4all.nl> <1218659496.25595.7.camel@fz.local> <20080813215023.GA23069@thorin> <1218667156.4010.5.camel@fz.local> <1218670230.4010.11.camel@fz.local> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 14 Aug 2008 09:13:40 +0200 In-Reply-To: <1218670230.4010.11.camel@fz.local> (Felix Zielcke's message of "Thu, 14 Aug 2008 01:30:30 +0200") Message-ID: <87vdy4yspn.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by mx20.gnu.org: FreeBSD 4.6-4.9 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2008 07:10:04 -0000 Felix Zielcke writes: > Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke: >> >> This time dear Marco I didn't bother to read through the changelog, it >> might be still not perfect and I'm even tired now. > > I should have better gone to bed instead of making quickly a patch for > this. > Well 2nd try now. > I forgot grub-fstest and I think I know now why you said `why' to one > entry ;) > And I forgot to change the copyright year to 2008 for the new shiny > util/err.c So this patch isn't really required, but you want it for Lenny? > 2008-08-14 Felix Zielcke > > * include/grub/err.h (grub_error_stack_assert): New variable > declaration. > * kern/err.c (grub_error_stack_assert): Remove static. > (grub_print_error): Disable it for [GRUB_UTIL] because ... > * util/err.c: New file with grub_print_error () using fprintf > (stderr, ...). Can you just use misc.c? > * conf/common.rmk: Add it for grub-probe. I have been thinking of an alternative way to fix this. A bit of a compromise between what you want and what I want and perhaps cleaner. You could define a function grub_err_printf or something like that. Which you use in grub_print_error. You can redefine it for GRUB_UTIL to grub_util_error and to grub_print otherwise. I didn't study the code. Will this be easier and cleaner? -- Marco