From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KOddv-0001UD-Mp
	for mharc-grub-devel@gnu.org; Thu, 31 Jul 2008 15:16:55 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KOddt-0001TO-UV
	for grub-devel@gnu.org; Thu, 31 Jul 2008 15:16:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KOddr-0001Sn-MB
	for grub-devel@gnu.org; Thu, 31 Jul 2008 15:16:52 -0400
Received: from [199.232.76.173] (port=46026 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KOddr-0001Sk-FW
	for grub-devel@gnu.org; Thu, 31 Jul 2008 15:16:51 -0400
Received: from smtp-vbr14.xs4all.nl ([194.109.24.34]:2883)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1KOddr-0001G6-5r
	for grub-devel@gnu.org; Thu, 31 Jul 2008 15:16:51 -0400
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr14.xs4all.nl (8.13.8/8.13.8) with ESMTP id m6VJGjmR017486
	for <grub-devel@gnu.org>; Thu, 31 Jul 2008 21:16:48 +0200 (CEST)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <ca0f59980807271052o18cfc7f4x57b12a4bd32a087e@mail.gmail.com>
	<20080727212509.GA24358@thorin>
	<ca0f59980807272208h1bdbf756y6e68c84b0b6fa0f6@mail.gmail.com>
Mail-Copies-To: mgerards@xs4all.nl
Date: Thu, 31 Jul 2008 21:18:53 +0200
In-Reply-To: <ca0f59980807272208h1bdbf756y6e68c84b0b6fa0f6@mail.gmail.com>
	(bean123ch@gmail.com's message of "Mon, 28 Jul 2008 13:08:26 +0800")
Message-ID: <87vdylj202.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: [PATCH] buffered file read
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jul 2008 19:16:54 -0000

Hi Bean,

Bean <bean123ch@gmail.com> writes:

> I have added a buffer length parameter to grub_buffile_open:
>
> grub_file_t grub_buffile_open (const char *name, int size);
>
> size < 0: Load the whole file.
> size = 0: Use default buffer size (8192 bytes)
> size > 0: Custom buffer size = size
>
> The upper limit is 1m, if size > 1m, we set it to 1m.
>
> 2008-07-28  Bean  <bean123ch@gmail.com>
>
> 	* conf/common.rmk (pkglib_MODULES): Add bufio.mod.
> 	(bufio_mod_SOURCES): New macro.
> 	(bufio_mod_CFLAGS): Likewise.
> 	(bufio_mod_LDFLAGS): Likewise.
>
> 	* include/grub/bufio.h: New file.
>
> 	* io/bufio.c: Likewise.
>
> 	* video/png.c (grub_video_reader_png): Use grub_buffile_open to open
> 	file.
>
> 	* video/jpeg.c (grub_video_reader_jpeg): Likewise.
>
> 	* video/tga.c (grub_video_reader_tga): Likewise.
>
> 	* font/manager.c (add_font): Likewise.

Please mention it when you include <include/grub/bufio.h>.  The same
for when you remove <include/grub/file.h>.

Otherwise it seems good for inclusion :-)

--
Marco