Re: [Printing-architecture] PDF CUPS filter packages

[Olaf Meeuwissen <olaf.meeuwissen@avasys.jp>]

Till Kamppeter <till.kamppeter@gmail.com> writes:

> Thank you, now the package rebuilds correctly for me. Next step to fix 
> now for you is to eliminate the necessity of full copies of the Poppler 
> and CUPS source code in the package.

For the record, the "errors" were caused by telling gcc to treat
warnings as errors (see snippet below).  I have not checked the
opfc-pdf-filters sources but this is not the default gcc behaviour,
AFAIK.

  make[2]: Entering directory 
  `/home/till/ubuntu/opfc-pdf-filters/tmp/opfc-pdf-filters-0.4/pdftopdf/src'
  g++ -DHAVE_CONFIG_H -I. -I.. 
  -I/home/till/ubuntu/opfc-pdf-filters/tmp/opfc-pdf-filters-0.4/poppler-0.6//poppler 
  -I/home/till/ubuntu/opfc-pdf-filters/tmp/opfc-pdf-filters-0.4/poppler-0.6/ 
  -DCONFFILE_DIR=\"/etc/cups\" -DPDFTOPDF 
  -I/home/till/ubuntu/opfc-pdf-filters/tmp/opfc-pdf-filters-0.4/poppler-0.6//poppler 
    -Wall -Werror -g -O2 -MT pdf2pdf-P2PCatalog.o -MD -MP -MF 
  .deps/pdf2pdf-P2PCatalog.Tpo -c -o pdf2pdf-P2PCatalog.o `test -f 
  'P2PCatalog.cc' || echo './'`P2PCatalog.cc
  cc1plus: warnings being treated as errors

While I am generally inclined to do this myself, it is a bit of a
mixed blessing as not all gcc versions of all distribution flag the
same things as warnings.  If adding your own warnings to -Wall, you
will very likely compound the issue.

In this particular case, converting string constants to `char *`, I
would say it should be fixed.

> [snip]

Hope this helps,
-- 
Olaf Meeuwissen                   FLOSS Engineer -- AVASYS Corporation
FSF Associate Member #1962           sign up at http://member.fsf.org/