From: Ed L Cashin <ecashin@coraid.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, Greg K-H <greg@kroah.com>,
Sam Hopkins <sah@coraid.com>
Subject: Re: [PATCH 2.6.14-rc2] aoe [1/2]: explicitly set minimum packet length to ETH_ZLEN
Date: Mon, 26 Sep 2005 15:09:47 -0400 [thread overview]
Message-ID: <87vf0n63yc.fsf@coraid.com> (raw)
In-Reply-To: <1127757933.27757.32.camel@localhost.localdomain> (Alan Cox's message of "Mon, 26 Sep 2005 19:05:32 +0100")
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> On Llu, 2005-09-26 at 12:50 -0400, Ed L Cashin wrote:
>> > skb = alloc_skb(len, GFP_ATOMIC);
>>
>> This change fixes some strange problems observed on a system that was
>> using the e1000 network driver. Is the network driver supposed to
>> ensure that ethernet packets are up to spec, at least 60 bytes long?
>
> The network driver is supposed to pad frames if the hardware cannot and
> to blank the spare bits.
Ah ha.
> If it isn't occurring please try and trace down
> the offender.
My colleague Sam observed problems with the e1000 driver in the
2.6.11.4-21.9-smp kernel from Suse 9.3 and also the e1000 driver in
2.6.12-1.1398_FC4smp from Fedora Core 4.
The problems aren't fully characterized, but AoE ATA read packets
appeared to be getting dropped and/or corrupted.
When using the tg3 driver instead of e1000 the problems went away, and
making the aoe driver alloc_skb with a minimum length of ETH_ZLEN also
made the problems go away.
--
Ed L Cashin <ecashin@coraid.com>
prev parent reply other threads:[~2005-09-26 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-26 16:43 [PATCH 2.6.14-rc2] aoe [1/2]: explicitly set minimum packet length to ETH_ZLEN Ed L. Cashin
2005-09-26 16:45 ` [PATCH 2.6.14-rc2] aoe [2/2]: use get_unaligned for possibly unaligned accesses in ATA id buffer Ed L. Cashin
2005-09-26 21:55 ` David S. Miller
2005-09-26 16:50 ` [PATCH 2.6.14-rc2] aoe [1/2]: explicitly set minimum packet length to ETH_ZLEN Ed L Cashin
2005-09-26 17:10 ` Valdis.Kletnieks
2005-09-26 17:25 ` Randy.Dunlap
2005-09-26 22:28 ` Ed L Cashin
2005-09-26 23:21 ` David S. Miller
2005-09-27 21:41 ` Ed L Cashin
2005-09-26 17:14 ` Ben Dooks
2005-09-26 18:05 ` Alan Cox
2005-09-26 19:09 ` Ed L Cashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vf0n63yc.fsf@coraid.com \
--to=ecashin@coraid.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sah@coraid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.