From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1C7JZE-0003FX-82
	for qemu-devel@nongnu.org; Tue, 14 Sep 2004 16:06:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1C7JZC-0003F9-Na
	for qemu-devel@nongnu.org; Tue, 14 Sep 2004 16:06:19 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1C7JZC-0003Ez-Jq
	for qemu-devel@nongnu.org; Tue, 14 Sep 2004 16:06:18 -0400
Received: from [195.122.192.2] (helo=janik.cz)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1C7JTD-0002XP-TA
	for qemu-devel@nongnu.org; Tue, 14 Sep 2004 16:00:09 -0400
From: Pavel@Janik.cz (=?iso-8859-2?q?Pavel_Jan=EDk?=)
Date: Tue, 14 Sep 2004 21:55:34 +0200
Message-ID: <87vfegmxqh.fsf@Janik.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] PATCH?: console.c warning
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

why compiling console.c, I get:

/home/pavel/QEMU/qemu-cvs/console.c:707: warning: assignment from
incompatible pointer type

I solved it in my tree with this:

--- vl.h.~1.52.~	2004-08-27 20:57:57.000000000 +0200
+++ vl.h	2004-09-14 21:52:45.184230080 +0200
@@ -188,7 +188,7 @@
                                  IOCanRWHandler *fd_can_read,=20
                                  IOReadHandler *fd_read, void *opaque);
     IOEventHandler *chr_event;
-    IOEventHandler *chr_send_event;
+    void (*chr_send_event) (struct CharDriverState *s, int event);
     void *opaque;
 } CharDriverState;
=20

Is this correct solution?
--=20
Pavel Jan=EDk

You're right, this should be fixed. Do you happen to have a patch?
                  -- Rik van Riel in linux-kernel about VM bug