From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3493606A325 for ; Mon, 9 Nov 2026 10:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GgoYCSAu Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xQMUu-0002Bz-LU; Mon, 09 Nov 2026 05:21:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xQMUn-0002Ad-65 for qemu-devel@nongnu.org; Mon, 09 Nov 2026 05:21:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xQMUl-0001Yt-La for qemu-devel@nongnu.org; Mon, 09 Nov 2026 05:21:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794219658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H3TKQYEAMPapOfHChH2hKQRUFNa4Ddw2aiciSWKf/1g=; b=GgoYCSAueUvYyCvgky7dR8aegDOkxQyh3MhL6VZrwmm8JjtZU8Mc4/GDRuiuObqy71hL9C HA2BqfFodHqjyvCnY/CjpN6iqMxXnPi6jz+XIga/AggNa6bRKvkKJIBCVOIOpYnc5JvpTR +1NP6ou4Tl2WjXfRPFl4ImQ8uvn7OR8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-MiNCPWJsMaeJ4DTVnOCFIA-1; Mon, 09 Nov 2026 05:20:55 -0500 X-MC-Unique: MiNCPWJsMaeJ4DTVnOCFIA-1 X-Mimecast-MFC-AGG-ID: MiNCPWJsMaeJ4DTVnOCFIA_1794219654 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 058A01955F72; Mon, 9 Nov 2026 10:20:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.7]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8AFC87E3; Mon, 9 Nov 2026 10:20:53 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 379C721E6A04; Mon, 09 Nov 2026 11:20:51 +0100 (CET) From: Markus Armbruster To: Mark Cave-Ayland Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com, milesg@linux.ibm.com, qemu-ppc@nongnu.org, qemu-arm@nongnu.org Subject: Re: [PATCH 6/8] hw/gpio/pca955x: use QAPI enums for led and pin properties In-Reply-To: (Mark Cave-Ayland's message of "Mon, 9 Nov 2026 09:05:46 +0000") References: <20261106110440.3552588-1-armbru@redhat.com> <20261106110440.3552588-7-armbru@redhat.com> Date: Mon, 09 Nov 2026 11:20:51 +0100 Message-ID: <87wlqm5mrg.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Mark Cave-Ayland writes: > On 06/11/2026 11:04, Markus Armbruster wrote: > >> From: Marc-Andr=C3=A9 Lureau >> Replace hand-rolled string lookup tables with QAPI enums >> Pca9552LedState and GpioPinState for the led%d and pin%d QOM >> properties. This lets QAPI handle string-to-enum conversion in the >> visitor, removing the manual string matching in the setters. >> Add QEMU_BUILD_BUG_ON guards to ensure the QAPI-generated enum values >> stay in sync with the hardware register encoding. >> Signed-off-by: Marc-Andr=C3=A9 Lureau [...] > I'm less confident with the QAPI side with all the recent changes to give= an R-B, however it seems sensible to me. Perhaps an Acked-by if you feel y= ou need it? Otherwise LGTM. Acked-by makes sense then, doesn't it?