From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227D7606A31A for ; Thu, 29 Oct 2026 19:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=mAsNuP+e Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xMViF-0002MW-BL; Thu, 29 Oct 2026 15:22:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xMViD-0002Lb-DJ for qemu-arm@nongnu.org; Thu, 29 Oct 2026 15:22:57 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xMViA-00068r-Kt for qemu-arm@nongnu.org; Thu, 29 Oct 2026 15:22:57 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-48df54150dfso1412225f8f.0 for ; Thu, 29 Oct 2026 12:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1793301773; x=1793906573; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :user-agent:references:in-reply-to:subject:cc:to:from:from:to:cc :subject:date:message-id:reply-to:content-type; bh=DdeaH5sdbARqzOfCM/WjGZQXc7n5RFXvCTy6trPqQKA=; b=mAsNuP+eFy+fMVWqUQIkKgC95MNXP8XjsjvtWXEN+2i3BZ1xyTpZI3Atjw+nAbNXxE ITwz7RWnzYg03ghCJ+axzPY8RCMlvfkFq7797BpK9dsSCpIHW04fyujiMxXCapA6Mqqw qPwkLaMla/N2uP6hGVrk+ikHstjKdHLrQp+oO88HggG97rh3ZHfYs2GtOCuGY0Qh1LE6 5JtZJswN2I17EbKt3rcnfpr70D+R8aFaJd1XQ4HD8f3DYFQ6VGobVRwxjohhT12ndhFa wa2RdXjIcxjOmLsxepvw5br951VJQcY6vh3Yyn5jfIXfsQPjorby+TA10sUw6OWB9dYA zO8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793301773; x=1793906573; h=content-transfer-encoding:content-type:mime-version:message-id:date :user-agent:references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DdeaH5sdbARqzOfCM/WjGZQXc7n5RFXvCTy6trPqQKA=; b=qpJcpPbVLqfn7glndHiAcaKjj4yYPH+QI3y9rptL9ByHJjuW6G+Arz95arh+m4DQqu oDB0olJINSlSKmS9B/m9OhEvIbJ2djD6pH5CQEpsJEHjOL3mskkwwpTLDwyhS8+U54Bq eatkVEyZjjxj3XCUdrLYk/T7NlXz6/viUXMS7fYCEIBfFiYf4kTzRugx8QeqhhiUO6HM l0DVprhOYdDO3bvsELiKBDdQALxHnuoVmgcJLfjvtOzfr8wZBRl3asNCgv2mQEqHXMrn sqDGLihVfX5mWbKhs3izWnYMffBNWJ6mWuV9qo4oGf+064tRPE+QLHadXDxTQYOgY59g 52vQ== X-Forwarded-Encrypted: i=1; AKwUvByvvPpGckvnJa5kR+SIRyqi+HEQLmlAKp81m/pS+gxkDC5SFBTVwZb3AaeeTHxHI4EpRdAKM8WOoQ==@nongnu.org X-Gm-Message-State: AFq9FYLHITcD/Bpt5V8zVjnszeEL9S5dyTyeZWh2DWpUu1M8fg0mfzdp VZ6tfpFlWDWIlnU5oeJZxz8mfmnZzsPBJuPdm4p3Gh9xvbkzsOowhwTfoDDVbtY5oCc= X-Gm-Gg: AYBFou3F3F/Cwv0PX8ocPUWKdjyiV9YY2kZBzCpy6IDX2bQqvSQWjG5ckcgskJ1XLy6 Owuo/wDu5BdtKX1Se34WHVj11oyOLOXqmQFxCxuLvcMFpHgfKPQjlN3o4pR1mEqkqNRzjdNfWzI Z1XdM3NTa2B0J2EES/Zn3RIJrBJCxh0zBvpM3f6l6wckbuLZt9ap7OWML4tVSEQ5bLcfRMcp6YS OIwjyLgnI6hlY2IJiekH50KNbyLzIc80OODSAlwnPYDrlzG/htF0c3A8fwo+T1wNkgbykqHLIix 2Hc9PpMAUnmBf+p7Kd2Rrum6C4cgW4WtIUDjpWufSZ7ch+xgYyq8gN34pqAOCHsKyuN+jOEIWoC ttnVwPbxgButJe5hEaOBhaqbjBEcDgnXS4B5Xi1Wehbuk+mXAXxI4EQv6GFCoGQtuL6ckS5c0Jm XTCWChu1xNCQuBOhywnSnYK4gwmEsSmXgBQucQZuZBZzvJC4P0jreJPSS/04kjT3mKRVifuO5zW 3i3K5I+RIA2jS7ktn/wy/RFDLHvSwmdAGipKw5W4iSCnes7P8qiNuBYXfSJiQS12EpnPC4bEqUv zhri5P82RR7YqNJSACF7J1Y/2DD1 X-Received: by 2002:a05:6000:2885:b0:488:88ec:59c3 with SMTP id ffacd0b85a97d-48e6e2f2c14mr778348f8f.14.1793301772857; Thu, 29 Oct 2026 12:22:52 -0700 (PDT) Received: from draig.lan ([185.124.0.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e6eb95384sm301834f8f.43.2026.10.29.12.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 12:22:52 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3DE015F898; Thu, 29 Oct 2026 19:22:51 +0000 (GMT) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Richard Henderson , Matthew Rosato , Peter Maydell , Christian Borntraeger , Eric Farman , Chao Liu , Tyrone Ting , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Hao Wu , Halil Pasic , qemu-arm@nongnu.org, Paolo Bonzini Subject: Re: [PATCH 1/8] scripts/checkpatch: validate fixes against origin/master In-Reply-To: (Pierrick Bouvier's message of "Thu, 29 Oct 2026 09:44:39 -0800") References: <20261029161310.2065290-1-alex.bennee@linaro.org> <20261029161310.2065290-2-alex.bennee@linaro.org> <8733toa05f.fsf@draig.linaro.org> User-Agent: mu4e 1.14.4; emacs 30.1 Date: Thu, 29 Oct 2026 19:22:51 +0000 Message-ID: <87wlr08g6s.fsf@draig.linaro.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Pierrick Bouvier writes: > On 10/29/2026 9:26 AM, Alex Benn=C3=A9e wrote: >> Pierrick Bouvier writes: >>=20 >>> On 10/29/2026 8:13 AM, Alex Benn=C3=A9e wrote: >>>> The current check for a referenced fix commit relies on the developer >>>> keeping their master branch up to date which is not always grunted. If >>>> you create your branches directly from origin/master this will keep >>>> failing. >>>> >>>> Given that origin/master should always be up to date (module the >>>> developer eschewing convention) lets use that in the test instead. >>>> >>>> checkpatch complains about the line lengths but this seems to be >>>> standard for the perl script so I didn't try and fix it. >>>> >>> >>> Or... you can use something else as origin, with origin/master not being >>> updated, and master as a tracking branch to upstream/master, and in this >>> case, this patch doesn't work. >>> >>> Using master instead of origin/master has the advantage to not hardcode >>> what your remotes should be. >>=20 >> origin is the default when you clone a repo. We could get really complex >> and query the tracking remote for the current branch. But if your deeply >> forked then that obviates the test. >> > > I am aware that origin is the default remote. > In my case, I always use "upstream" to reference the original project, > and "origin" for my personal fork. As a result, origin/master does not > always track upstream/master. So master in that case won't be correct either? --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro