All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Harrison Lucas <tiiowsalt@gmail.com>
Cc: linux-sound@vger.kernel.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: hda/realtek: Fix mute and micmute LEDs on HP ENVY x360 15-ey0xxx
Date: Wed, 30 Sep 2026 14:31:34 +0200	[thread overview]
Message-ID: <87wls253a1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260929174348.167537-1-tiiowsalt@gmail.com>

On Tue, 29 Sep 2026 19:43:48 +0200,
Harrison Lucas wrote:
> 
> The HP ENVY x360 2-in-1 Laptop 15-ey0xxx (SSID 103c:8a31, ALC245 with
> CS35L41 I2C amps) currently only gets ALC287_FIXUP_CS35L41_I2C_2, so the
> mute and micmute LEDs on the keyboard never light up.
> 
> On this machine the mute LED is driven by COEF 0x0b bits 2-3 and the
> micmute LED by GPIO 0x04 (active low), which is exactly what
> ALC245_FIXUP_HP_X360_MUTE_LEDS sets up. Switch the quirk to
> ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS, which keeps the CS35L41 setup
> and chains to that LED fixup.
> 
> Verified by driving the COEF and GPIO values by hand with hda-verb,
> following Master Playback Switch and Mic ACP LED Capture Switch.
> 
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Harrison Lucas <tiiowsalt@gmail.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-09-30 12:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 17:43 [PATCH] ALSA: hda/realtek: Fix mute and micmute LEDs on HP ENVY x360 15-ey0xxx Harrison Lucas
2026-09-30 12:31 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wls253a1.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=tiiowsalt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.