All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>,
	qemu-arm@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>,
	"John Snow" <jsnow@redhat.com>,
	"David Hildenbrand" <david@kernel.org>,
	"Thomas Huth" <th.huth+qemu@posteo.eu>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>, "Warner Losh" <imp@bsdimp.com>,
	"Song Gao" <gaosong@loongson.cn>,
	"Kyle Evans" <kevans@freebsd.org>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Brad Smith" <brad@comstyle.com>,
	"Fabiano Rosas" <farosas@suse.de>, "Helge Deller" <deller@gmx.de>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	qemu-s390x@nongnu.org, "Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Brian Cain" <brian.cain@oss.qualcomm.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v4 02/19] Revert "tests/tcg/meson.build: implement ./configure -cross-cc-* options"
Date: Thu, 17 Sep 2026 14:24:43 +0100	[thread overview]
Message-ID: <87wlsk6mec.fsf@draig.linaro.org> (raw)
In-Reply-To: <65a743c6-54ae-4e2c-ae4d-08e1d6f87ef3@oss.qualcomm.com> (Pierrick Bouvier's message of "Wed, 16 Sep 2026 09:31:45 -0700")

Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> writes:

> On 9/16/2026 8:29 AM, Alex Bennée wrote:
>> We want to keep configuring of the cross compiler within configure so
>> it can be used by the firmware.
>>
>
> Would that be possible to add in command message that it disable effect
> of those options for tcg-tests?

I'm wondering if we should revert this at all, or just merge with the
meson commands (because currently this breaks the MacOS tcg checks)
>
>> This reverts commit 7e1d54da6faf10e1fc70f6b3d8247068b80b1597.
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> 
>> ---
>> v3
>>   - declare empty container_command/use_containers to avoid unref var
>> ---
>>  configure             | 31 ++++++++-------
>>  meson_options.txt     | 89 -------------------------------------------
>>  tests/tcg/meson.build | 31 +++------------
>>  3 files changed, 23 insertions(+), 128 deletions(-)
>> 
>
> For the rest,
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
>
> Regards,
> Pierrick

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2026-09-17 13:25 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 15:29 [PATCH v4 00/19] testing: various docker clean-ups post meson tcg conversion Alex Bennée
2026-09-16 15:29 ` [PATCH v4 01/19] Revert "configure: remove cross_cc and gdb detection logic" Alex Bennée
2026-09-16 15:29 ` [PATCH v4 02/19] Revert "tests/tcg/meson.build: implement ./configure -cross-cc-* options" Alex Bennée
2026-09-16 16:31   ` Pierrick Bouvier
2026-09-17 13:24     ` Alex Bennée [this message]
2026-09-17 16:57       ` Pierrick Bouvier
2026-09-16 15:29 ` [PATCH v4 03/19] Revert "tests/tcg/meson.build: implement ./configure containers options" Alex Bennée
2026-09-16 16:33   ` Pierrick Bouvier
2026-09-17  9:27     ` Alex Bennée
2026-09-17 16:58       ` Pierrick Bouvier
2026-09-16 15:29 ` [PATCH v4 04/19] configure: correctly honour --disable-containers Alex Bennée
2026-09-16 15:29 ` [PATCH v4 05/19] configure: re-purpose the tcg test compiler configs for vdso building Alex Bennée
2026-09-16 16:50   ` Pierrick Bouvier
2026-09-16 15:29 ` [PATCH v4 06/19] tests/tcg/s390x: Provide the libc bits needed by the system tests Alex Bennée
2026-09-16 15:30 ` [PATCH v4 07/19] tests/tcg: prefix meson built docker tags with qemu/ Alex Bennée
2026-09-16 20:15   ` Richard Henderson
2026-09-16 15:30 ` [PATCH v4 08/19] tests/tcg: use --add-current-user when building containers Alex Bennée
2026-09-16 16:35   ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 09/19] tests/tcg: don't define tests when missing compilers Alex Bennée
2026-09-16 16:41   ` Pierrick Bouvier
2026-09-17  0:00     ` Richard Henderson
2026-09-17  6:53       ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 10/19] tests/docker: add container registry to configure and use Alex Bennée
2026-09-16 16:41   ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 11/19] tests/docker: remove used _read_qemu_dockerfile Alex Bennée
2026-09-16 15:30 ` [PATCH v4 12/19] tests/docker: strip remaining caching logic from docker.py Alex Bennée
2026-09-16 15:30 ` [PATCH v4 13/19] tests/docker: add specific command to parser Alex Bennée
2026-09-16 15:30 ` [PATCH v4 14/19] tests/docker: swap --quiet for --verbose Alex Bennée
2026-09-16 16:49   ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 15/19] tests/docker: fix brown bag typo for docker-ccache Alex Bennée
2026-09-16 16:43   ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 16/19] gitlab: update the @user id mapping file Alex Bennée
2026-09-16 16:12   ` Amit Machhiwal
2026-09-16 15:30 ` [PATCH v4 17/19] scripts/make2mtest: add docker dependencies for check-tcg-% targets Alex Bennée
2026-09-16 16:30   ` Pierrick Bouvier
2026-09-17  9:29     ` Alex Bennée
2026-09-17 16:59       ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 18/19] tests/tcg: add console property to docker image custom target Alex Bennée
2026-09-16 16:53   ` Pierrick Bouvier
2026-09-16 15:30 ` [PATCH v4 19/19] tests/tcg: Fix building outside of the source tree Alex Bennée
2026-09-16 23:59 ` [PATCH v4 00/19] testing: various docker clean-ups post meson tcg conversion Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlsk6mec.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=brad@comstyle.com \
    --cc=brian.cain@oss.qualcomm.com \
    --cc=cohuck@redhat.com \
    --cc=crosa@redhat.com \
    --cc=david@kernel.org \
    --cc=deller@gmx.de \
    --cc=farman@linux.ibm.com \
    --cc=farosas@suse.de \
    --cc=gaosong@loongson.cn \
    --cc=iii@linux.ibm.com \
    --cc=imp@bsdimp.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jsnow@redhat.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=marcandre.lureau@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@mailo.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=th.huth+qemu@posteo.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.