Re: [PATCH 1/2] libavb: update to AOSP 1.3.0

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Igor,

Thank you for the patch.

On Sun, Jul 12, 2026 at 16:07, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:

> Re-sync the vendored libavb from AOSP external/avb, moving from the ~2019
> snapshot (v1.1.0) to v1.3.0. v1.1.0 rejected any vbmeta whose required
> libavb minor version was greater than 1 with UNSUPPORTED_VERSION; this
> lifts that ceiling and picks up the accumulated upstream fixes.
>
> Synced from commit a1fe228b8654 ("libavb: support chain partition no ab"),
> which is where AVB version 1.3.0 was introduced (the vendored files match
> this commit exactly), for more details check [1].
>
> Functionality now parsed by the library:
>   - AvbVBMetaImageHeader.rollback_index_location (v1.2)
>   - AvbChainPartitionDescriptor flags / DO_NOT_USE_AB (v1.3)
>   - AvbHashtreeDescriptor FLAGS_CHECK_AT_MOST_ONCE
>   - AVB_HASHTREE_ERROR_MODE_PANIC
>
> The AvbOps callback set is unchanged, so the integration layer in
> common/avb_verify.c needs no changes.
>
> U-Boot-specific adaptations are preserved rather than pulling upstream's
> BoringSSL-oriented crypto restructure (sha/, boringssl/): the U-Boot port
> in avb_sysdeps.h / avb_sysdeps_posix.c and the flat avb_sha.h /
> avb_sha256.c / avb_sha512.c are kept as-is. The SHA API signatures are
> unchanged, so the retained implementation is compatible with the updated
> code.
>
> Imported files keep U-Boot's SPDX-License-Identifier header style
> and their upstream per-file licenses (avb_rsa.c stays MIT OR
> BSD-3-Clause). The unused, Apache-2.0-licensed avb_crc32.c is not
> imported.
>
> [1] https://android.googlesource.com/platform/external/avb/+/a1fe228b86543a21739c51352f5ce72f134fccfa
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>

I've reviewed this by comparing all the files with the reference
implementation from AOSP's external/avb.

This looks good to me, thanks!

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>