Re: [PATCH] tests/docker: add flex and bison to emsdk-wasm64-cross

["Alex Bennée" <alex.bennee@linaro.org>]

Philippe Mathieu-Daudé <philmd@oss.qualcomm.com> writes:

> On 24/6/26 07:48, Brian Cain wrote:
>> The hexagon idef-parser requires flex and bison as host build
>> tools.  Add them to the emsdk-wasm64-cross container image so that
>> wasm64 builds including hexagon-softmmu can find them.
>> Link:
>> https://lore.kernel.org/qemu-devel/CAJSP0QVk6wsOnPAspC4YfXRp90saKibQfD4Mk-44-RQo0k=z3w@mail.gmail.com/
>> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
>> ---
>>   tests/docker/dockerfiles/emsdk-wasm64-cross.docker | 2 ++
>>   1 file changed, 2 insertions(+)
>> diff --git a/tests/docker/dockerfiles/emsdk-wasm64-cross.docker
>> b/tests/docker/dockerfiles/emsdk-wasm64-cross.docker
>> index 8a924816f92..5debbc77d08 100644
>> --- a/tests/docker/dockerfiles/emsdk-wasm64-cross.docker
>> +++ b/tests/docker/dockerfiles/emsdk-wasm64-cross.docker
>> @@ -19,7 +19,9 @@ ENV CXXFLAGS="$CFLAGS"
>>   ENV LDFLAGS="-sWASM_BIGINT -sASYNCIFY=1 -L$TARGET/lib"
>>   RUN apt-get update && apt-get install -y \
>>       autoconf \
>> +    bison \
>>       build-essential \
>> +    flex \
>>       libglib2.0-dev \
>>       libtool \
>>       pkgconf \
>
> Maybe emsdk-wasm64 should have been added to lci-tool first.
> (not your responsibility).

I don't think that will be easy on account of emsdk having to build a
bunch of libraries to support building QEMU. If a distro provides a
better cross environment for wasm64 then we could try.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro