All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dominique MARTINET <dominique.martinet@atmark-techno.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,  Steam Lin <stlin2@winbond.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Md Sadre Alam <quic_mdalam@quicinc.com>,
	 Sridharan S N <quic_sridsn@quicinc.com>
Subject: Re: [PATCH 4/4] mtd: spi-nand: winbond: Sort the devices
Date: Mon, 18 May 2026 11:56:02 +0200	[thread overview]
Message-ID: <87wlx1t51p.fsf@bootlin.com> (raw)
In-Reply-To: <agrZHsyrm1jyFMj6@atmark-techno.com> (Dominique MARTINET's message of "Mon, 18 May 2026 18:17:18 +0900")

On 18/05/2026 at 18:17:18 +09, Dominique MARTINET <dominique.martinet@atmark-techno.com> wrote:

> Miquel Raynal wrote on Wed, Oct 09, 2024 at 02:50:02PM +0200:
>> Use alphabetical order, not because it's pretty, but because it makes
>> sense. This way the devices are listed by density, and then by hardware
>> feature set. Add comments to make the list more understandable.
>> 
>> There is no intended functional change.
>
> Probably won't matter for most people, but FWIW this commit added
> W25N04KW, and thus was not only a re-order (I assume sorting made you
> notice it was missing, but forgot to split it out)
>
> This has the side-effect that this particular nand won't work on stable
> trees (device additions are usually backported to recent kernels), but
> I'm not sure it's worth the effort to send a stable patch just for that,
> I just wanted to point it out in case someone else searchs for this string
> or 6.12 kernels or older:
> spi-nand spi0.0: unknown raw ID efba230000
>
>
> $ git show 25f643a3d73ff9f559339dba6ac35bedd8f8e4f6 | rg '^[+-][ \t]*SPINAND_INFO\(' | sort

[...]

> +	SPINAND_INFO("W25N04KW", /* 1.8V */

Crap. Indeed I don't think it's a bit problem, but yeah, sorry for
missing this, it should have been split.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2026-05-18  9:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 12:49 [PATCH 0/4] mtd: spinand: winbond: Fix chip descriptions Miquel Raynal
2024-10-09 12:49 ` [PATCH 1/4] mtd: spi-nand: winbond: Fix 512GW and 02JW OOB layout Miquel Raynal
2024-10-09 12:49   ` Miquel Raynal
2024-10-09 13:16   ` Frieder Schrempf
2024-10-09 13:16     ` Frieder Schrempf
2024-10-21 10:02   ` Miquel Raynal
2024-10-21 10:02     ` Miquel Raynal
2024-10-09 12:50 ` [PATCH 2/4] mtd: spi-nand: winbond: Fix 512GW, 01GW, 01JW and 02JW ECC information Miquel Raynal
2024-10-09 12:50   ` Miquel Raynal
2024-10-09 13:33   ` Frieder Schrempf
2024-10-09 13:33     ` Frieder Schrempf
2024-10-09 14:47     ` Miquel Raynal
2024-10-09 14:47       ` Miquel Raynal
2024-10-21 10:02   ` Miquel Raynal
2024-10-21 10:02     ` Miquel Raynal
2024-10-09 12:50 ` [PATCH 3/4] mtd: spi-nand: winbond: Ignore the last ID characters Miquel Raynal
2024-10-09 13:33   ` Frieder Schrempf
2024-10-21 10:02   ` Miquel Raynal
2024-10-09 12:50 ` [PATCH 4/4] mtd: spi-nand: winbond: Sort the devices Miquel Raynal
2024-10-09 13:36   ` Frieder Schrempf
2026-05-18  9:17   ` Dominique MARTINET
2026-05-18  9:56     ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlx1t51p.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=dominique.martinet@atmark-techno.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=pratyush@kernel.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_sridsn@quicinc.com \
    --cc=richard@nod.at \
    --cc=stlin2@winbond.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.