Re: [PATCH v2] generate-configlist: collapse depfile for older Ninja

[Toon Claes <toon@iotcl.com>]

Phillip Wood <phillip.wood123@gmail.com> writes:

> I don't think this use of '\n' portable. The sed man page [1] says that 
> '\n' matches a newline in the pattern space, but does not mention it 
> being supported in the replacement string. We do have an existing use in 
> t4150-am.sh:"am newline in subject" which does
>
> 	sed -e "s/second/second \\\n foo/" patch1 >patchnl &&
>
> However if I add "cat patchnl" it shows the subject line is
>
> 	Subject: [PATCH] second \n foo
>
> so sed has inserted "\n" rather than a newline. Indeed looking at the 
> commit message for that test it is testing a fix that c escapes are 
> printed verbatim introduced by 4b7cc26a74 (git-am: use printf instead of 
> echo on user-supplied strings, 2007-05-25).
>
> I've not tested it but I think
>
> 	sed 's/ $/\
> /'
>
> will insert a newline. Alternatively we could do
>
> 	printf '%s' "$QUOTED_OUTPUT: "
> 	printf '%s\n' "$SOURCE_DIR"/Documentation/*config.adoc \
>   			"$SOURCE_DIR"/Documentation/config/*.adoc |
> 		sed -e 's/[# ]/\\&/g' |
> 		tr '\n' ' '
> 	printf '\n'

Whoops, I somehow archived your reply without addressing it. Thanks for
finding this. I've sent out v3 with this suggestion.

--
Toon