From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Ivan Orlov <ivan.orlov0322@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcmtest: Fix resource leaks in module init error paths
Date: Tue, 21 Apr 2026 18:19:09 +0200 [thread overview]
Message-ID: <87wly08ewy.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260421-alsa-pcmtest-init-unwind-v1-1-03fe0c423dbb@gmail.com>
On Tue, 21 Apr 2026 15:03:06 +0200,
Cássio Gabriel wrote:
>
> pcmtest allocates its pattern buffers and creates its debugfs tree
> before registering the platform device and driver, but mod_init()
> does not release those resources when a later init step fails.
>
> As a result, a debugfs directory creation failure leaks the pattern
> buffers, while platform_device_register() and
> platform_driver_register() failures leave both the pattern buffers
> and the debugfs tree behind. The recent fix for failed device
> registration only dropped the embedded device reference.
>
> Add the missing cleanup for the debugfs tree and pattern buffers in
> the remaining module init error paths.
>
> Fixes: 315a3d57c64c ("ALSA: Implement the new Virtual PCM Test Driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2026-04-21 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 13:03 [PATCH] ALSA: pcmtest: Fix resource leaks in module init error paths Cássio Gabriel
2026-04-21 16:19 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wly08ewy.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=ivan.orlov0322@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.