All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
Subject: Re: [PATCH] dfu: Correct dependencies for DFU_TFTP
Date: Thu, 26 Mar 2026 09:56:44 +0100	[thread overview]
Message-ID: <87wlyzge9f.fsf@kernel.org> (raw)
In-Reply-To: <20260317012435.4162538-1-trini@konsulko.com>

Hi Tom,

Thank you for the patch.

On Mon, Mar 16, 2026 at 19:24, Tom Rini <trini@konsulko.com> wrote:

> As exposed by "make randconfig", we have an issue with the dependencies
> for DFU_TFTP. This really depends on the legacy networking stack being
> enabled, not just lwIP not being enabled (as it will fail in the NO_NET
> case).
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
>  drivers/dfu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 962bda40ad2d..1d5d8caa7daa 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -20,7 +20,7 @@ if DFU
>  config DFU_TFTP
>  	bool "DFU via TFTP"
>  	depends on NETDEVICES
> -	depends on !NET_LWIP
> +	depends on NET # Legacy stack only
>  	select UPDATE_COMMON
>  	select DFU_OVER_TFTP
>  	help
> -- 
> 2.43.0

  reply	other threads:[~2026-03-26  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  1:24 [PATCH] dfu: Correct dependencies for DFU_TFTP Tom Rini
2026-03-26  8:56 ` Mattijs Korpershoek [this message]
2026-04-08  9:26 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlyzge9f.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.