All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>,
	lukma@denx.de, mkorpershoek@kernel.org, marex@denx.de,
	trini@konsulko.com, kever.yang@rock-chips.com, jonas@kwiboo.se,
	quentin.schulz@cherry.de, gchan9527@gmail.com,
	balaji.selvanathan@oss.qualcomm.com, u-boot@lists.denx.de,
	Casey Connolly <casey.connolly@linaro.org>
Subject: Re: [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used
Date: Mon, 05 Jan 2026 10:40:52 +0100	[thread overview]
Message-ID: <87wm1wflcr.fsf@kernel.org> (raw)
In-Reply-To: <20251224044747.3898137-1-balaji.selvanathan@oss.qualcomm.com>

Hi Balaji,

Thank you for the patch.

On Wed, Dec 24, 2025 at 10:17, Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com> wrote:

> Correct ARCH_QCOM to ARCH_SNAPDRAGON as ARCH_QCOM is outdated/unused
> config. Using ARCH_QCOM was causing USB fastboot mode to fail.
>
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Acked-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

Casey, this is assigned to you on patchwork. Feel free to pick it up.

If you want me to take it instead, please assign to me on patchwork!

Mattijs

> ---
> v2:
> - Corrected ARCH_QCOM to ARCH_SNAPDRAGON
> - Link to v1: https://lore.kernel.org/u-boot/20251114063507.3834973-1-balaji.selvanathan@oss.qualcomm.com/
> ---
>  drivers/usb/gadget/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 7e08aeab904..ebb306852a6 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -61,7 +61,7 @@ config USB_GADGET_VENDOR_NUM
>  	default 0x0955 if ARCH_TEGRA
>  	default 0x1f3a if ARCH_SUNXI
>  	default 0x2207 if ARCH_ROCKCHIP
> -	default 0x18d1 if ARCH_QCOM
> +	default 0x18d1 if ARCH_SNAPDRAGON
>  	default 0x0
>  	help
>  	  Vendor ID of the USB device emulated, reported to the host device.
> @@ -89,7 +89,7 @@ config USB_GADGET_PRODUCT_NUM
>  	default 0x350b if ROCKCHIP_RK3588
>  	default 0x350c if ROCKCHIP_RK3528
>  	default 0x350e if ROCKCHIP_RK3576
> -	default 0x4ee0 if ARCH_QCOM
> +	default 0x4ee0 if ARCH_SNAPDRAGON
>  	default 0x0
>  	help
>  	  Product ID of the USB device emulated, reported to the host device.
> -- 
> 2.34.1

  parent reply	other threads:[~2026-01-05  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-24  4:47 [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used Balaji Selvanathan
2025-12-26  7:40 ` Sumit Garg
2026-01-05  9:40 ` Mattijs Korpershoek [this message]
2026-01-16 18:03 ` Casey Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wm1wflcr.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=gchan9527@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=lukma@denx.de \
    --cc=marex@denx.de \
    --cc=quentin.schulz@cherry.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.