From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert" <dave@treblig.org>
Cc: qemu-devel@nongnu.org, arei.gonglei@huawei.com,
pizhenwei@bytedance.com, alistair.francis@wdc.com,
stefanb@linux.vnet.ibm.com, kwolf@redhat.com,
hreitz@redhat.com, sw@weilnetz.de, qemu_oss@crudebyte.com,
groug@kaod.org, mst@redhat.com, imammedo@redhat.com,
anisinha@redhat.com, kraxel@redhat.com, shentey@gmail.com,
npiggin@gmail.com, harshpb@linux.ibm.com,
sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org,
edgar.iglesias@gmail.com, elena.ufimtseva@oracle.com,
jag.raman@oracle.com, sgarzare@redhat.com, pbonzini@redhat.com,
fam@euphon.net, philmd@linaro.org, alex@shazbot.org,
clg@redhat.com, peterx@redhat.com, farosas@suse.de,
lizhijian@fujitsu.com, jasowang@redhat.com,
samuel.thibault@ens-lyon.org, michael.roth@amd.com,
kkostiuk@redhat.com, zhao1.liu@intel.com, mtosatti@redhat.com,
rathc@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
marcandre.lureau@redhat.com, qemu-block@nongnu.org,
qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH 03/14] tap-solaris: Use error_setg_file_open() for better error messages
Date: Fri, 21 Nov 2025 06:35:03 +0100 [thread overview]
Message-ID: <87wm3kq77c.fsf@pond.sub.org> (raw)
In-Reply-To: <aR-xJgDErvQaN600@gallifrey> (David Alan Gilbert's message of "Fri, 21 Nov 2025 00:24:06 +0000")
"Dr. David Alan Gilbert" <dave@treblig.org> writes:
> * Markus Armbruster (armbru@redhat.com) wrote:
>> Error messages change from
>>
>> Can't open /dev/ip (actually /dev/udp)
>> Can't open /dev/tap
>> Can't open /dev/tap (2)
>>
>> to
>>
>> Could not open '/dev/udp': REASON
>> Could not open '/dev/tap': REASON
>>
>> where REASON is the value of strerror(errno).
>
> I guess the new macro has a __LINE__ so the (2) is redundant.
It does capture __FILE__, __LINE__, and __func__, but they're only
printed for &error_abort.
How likely is it that the first open of /dev/tap succeeds, and the
second fails?
Do users users then need to know that the second failed? If yes, then
" (2)" is a terrible way to tell them.
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Thanks!
next prev parent reply other threads:[~2025-11-21 5:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 19:13 [PATCH 00/14] Error message improvements Markus Armbruster
2025-11-20 19:13 ` [PATCH 01/14] error: Strip trailing '\n' from error string arguments (again) Markus Armbruster
2025-11-20 19:13 ` [PATCH 02/14] hw/usb: Use error_setg_file_open() for a better error message Markus Armbruster
2025-11-21 0:42 ` Dr. David Alan Gilbert
2025-11-21 5:28 ` Markus Armbruster
2025-11-20 19:13 ` [PATCH 03/14] tap-solaris: Use error_setg_file_open() for better error messages Markus Armbruster
2025-11-21 0:24 ` Dr. David Alan Gilbert
2025-11-21 5:35 ` Markus Armbruster [this message]
2025-11-20 19:13 ` [PATCH 04/14] qga: " Markus Armbruster
2025-11-21 1:12 ` Dr. David Alan Gilbert
2025-11-21 7:39 ` Kostiantyn Kostiuk
2025-11-20 19:13 ` [PATCH 05/14] hw/scsi: Use error_setg_file_open() for a better error message Markus Armbruster
2025-11-21 2:05 ` Dr. David Alan Gilbert
2025-11-20 19:13 ` [PATCH 06/14] hw/virtio: " Markus Armbruster
2025-11-20 19:13 ` [PATCH 07/14] net/tap: " Markus Armbruster
2025-11-20 19:13 ` [PATCH 08/14] blkdebug: " Markus Armbruster
2025-11-20 19:13 ` [PATCH 09/14] error: Use error_setg_file_open() for simplicity and consistency Markus Armbruster
2025-11-20 23:57 ` Dr. David Alan Gilbert
2025-11-21 5:45 ` Markus Armbruster
2025-11-21 17:45 ` Dr. David Alan Gilbert
2025-11-22 7:36 ` Markus Armbruster
2025-11-22 11:53 ` BALATON Zoltan
2025-11-22 13:58 ` Dr. David Alan Gilbert
2025-11-20 19:13 ` [PATCH 10/14] net/slirp: Improve file open error message Markus Armbruster
2025-11-20 19:13 ` [PATCH 11/14] error: Use error_setg_errno() to improve error messages Markus Armbruster
2025-11-21 0:10 ` Dr. David Alan Gilbert
2025-11-21 5:46 ` Markus Armbruster
2025-11-21 7:37 ` Markus Armbruster
2025-11-20 19:13 ` [PATCH 12/14] error: Use error_setg_errno() for simplicity and consistency Markus Armbruster
2025-11-21 0:15 ` Dr. David Alan Gilbert
2025-11-21 5:47 ` Markus Armbruster
2025-11-21 7:42 ` Markus Armbruster
2025-11-20 19:13 ` [PATCH 13/14] qga/commands-win32: Use error_setg_win32() for better error messages Markus Armbruster
2025-11-21 7:43 ` Kostiantyn Kostiuk
2025-11-20 19:13 ` [PATCH 14/14] block/file-win32: Improve an error message Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm3kq77c.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alex@shazbot.org \
--cc=alistair.francis@wdc.com \
--cc=anisinha@redhat.com \
--cc=anthony@xenproject.org \
--cc=arei.gonglei@huawei.com \
--cc=clg@redhat.com \
--cc=dave@treblig.org \
--cc=dbarboza@ventanamicro.com \
--cc=edgar.iglesias@gmail.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=groug@kaod.org \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=jag.raman@oracle.com \
--cc=jasowang@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=liwei1518@gmail.com \
--cc=lizhijian@fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pizhenwei@bytedance.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=rathc@linux.ibm.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=sgarzare@redhat.com \
--cc=shentey@gmail.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.