From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB06ACE8D79 for ; Fri, 14 Nov 2025 18:42:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AE0610E276; Fri, 14 Nov 2025 18:42:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CO2ZmoX9"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8E3D10E276 for ; Fri, 14 Nov 2025 18:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763145778; x=1794681778; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=qSaW3yei2xqFegaGHjCI9/LsvRjeGSVmbDSaH0S/vE8=; b=CO2ZmoX9pOCXQvlEOE95ifBde52iQzSzT4Bac/7wgv2A4joX+o8pS14o a8RtUZxgh0GaBRK4AfOgyAA1Cknya9lQ4QNYK6dkbJU9KOf8XPoX4VUGo psH3J84qOho1eKFwmSlzcpMqmf9YYGSZe1iRnR/PZScs9eP2z7Um1ho1/ ANsn9sQjMionzOkqrpOuM8upqkKglDgOzQ8MlkhxspG6uHEQpintj9PCZ QYOBLpLiGLQxdrk8nOyWHV2IpSajmZMDBpamovh2Axn4o0Bm6e33oWHVi FQ2mixCb5lc2c54FnPtP0WjnvYMPD0tktOY+LubVPnT4Xkv8mqggYvjrS g==; X-CSE-ConnectionGUID: M/qLtvdnQFmfmny2JWGvkA== X-CSE-MsgGUID: +heynF+DT5CTys3+3Hjp5A== X-IronPort-AV: E=McAfee;i="6800,10657,11613"; a="76591231" X-IronPort-AV: E=Sophos;i="6.19,305,1754982000"; d="scan'208";a="76591231" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2025 10:42:57 -0800 X-CSE-ConnectionGUID: v0ELDyvRTV+yXPNUhp/gxA== X-CSE-MsgGUID: 50MVEZ1ZT4C3e9XEvIWx7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,305,1754982000"; d="scan'208";a="193946466" Received: from rohitsub-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.177.125]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2025 10:42:57 -0800 Date: Fri, 14 Nov 2025 10:42:56 -0800 Message-ID: <87wm3stpzj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , Shekhar Chauhan , igt-dev@lists.freedesktop.org, ashutosh.dixit@intel.com Subject: Re: [PATCH] lib: Replace NVL with NVL-S In-Reply-To: <20251114153528.7b3dusuru2fx4quf@kamilkon-DESK.igk.intel.com> References: <20251114062042.1853554-1-shekhar.chauhan@intel.com> <20251114153528.7b3dusuru2fx4quf@kamilkon-DESK.igk.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 14 Nov 2025 07:35:28 -0800, Kamil Konieczny wrote: > > Hi Shekhar, > On 2025-11-14 at 11:50:42 +0530, Shekhar Chauhan wrote: > > Fix NVL-S' definition, by replacing Novalake with Novalake-S. > > Remove \' char after S. > > > > > Fixes: 480fa21b8 lib: Add NVL-S support > > This should follow convention: 12+ chars for hash and ("title"), > here: > > Fixes: 480fa21b82c2 ("lib: Add NVL-S support") > > Signed-off-by: Shekhar Chauhan > > With above fixed this is > Reviewed-by: Kamil Konieczny I made these changes and merged the patch. Thanks! > > Regards, > Kamil > > > --- > > lib/intel_chipset.h | 4 ++-- > > lib/intel_device_info.c | 8 ++++---- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h > > index 7739f4a84..cc2225110 100644 > > --- a/lib/intel_chipset.h > > +++ b/lib/intel_chipset.h > > @@ -93,7 +93,7 @@ struct intel_device_info { > > bool is_lunarlake : 1; > > bool is_battlemage : 1; > > bool is_pantherlake : 1; > > - bool is_novalake: 1; > > + bool is_novalake_s: 1; > > bool is_crescentisland: 1; > > > > const struct intel_cmds_info *cmds_info; > > @@ -212,7 +212,7 @@ void intel_check_pch(void); > > #define IS_LUNARLAKE(devid) (intel_get_device_info(devid)->is_lunarlake) > > #define IS_BATTLEMAGE(devid) (intel_get_device_info(devid)->is_battlemage) > > #define IS_PANTHERLAKE(devid) (intel_get_device_info(devid)->is_pantherlake) > > -#define IS_NOVALAKE(devid) (intel_get_device_info(devid)->is_novalake) > > +#define IS_NOVALAKE_S(devid) (intel_get_device_info(devid)->is_novalake_s) > > #define IS_CRESCENTISLAND(devid) (intel_get_device_info(devid)->is_crescentisland) > > > > #define IS_GEN(devid, x) (intel_get_device_info(devid)->graphics_ver == x) > > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c > > index d33bf39d4..20147479a 100644 > > --- a/lib/intel_device_info.c > > +++ b/lib/intel_device_info.c > > @@ -539,14 +539,14 @@ static const struct intel_device_info intel_pantherlake_info = { > > .cmds_info = &xe2_cmds_info, > > }; > > > > -static const struct intel_device_info intel_novalake_info = { > > +static const struct intel_device_info intel_novalake_s_info = { > > .graphics_ver = 30, > > .graphics_rel = 04, > > .display_ver = 35, > > .has_4tile = true, > > .has_oam = true, > > - .is_novalake = true, > > - .codename = "novalake", > > + .is_novalake_s = true, > > + .codename = "novalake_s", > > .cmds_info = &xe2_cmds_info, > > }; > > > > @@ -678,7 +678,7 @@ static const struct pci_id_match intel_device_match[] = { > > > > INTEL_PTL_IDS(INTEL_PCI_ID_INIT, &intel_pantherlake_info), > > > > - INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_info), > > + INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_s_info), > > > > INTEL_CRI_IDS(INTEL_PCI_ID_INIT, &intel_crescentisland_info), > > > > -- > > 2.51.1 > >