From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Peter Robinson <pbrobinson@gmail.com>,
Andrew Goodbody <andrew.goodbody@linaro.org>,
Guillaume La Roque <glaroque@baylibre.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jerome Forissier <jerome.forissier@linaro.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Maximilian Brune <maximilian.brune@9elements.com>,
Moritz Fischer <moritzf@google.com>
Subject: Re: [PATCH v4 2/4] boot: Move obtaining the label into a common file
Date: Fri, 10 Oct 2025 16:11:51 +0200 [thread overview]
Message-ID: <87wm52vobc.fsf@kernel.org> (raw)
In-Reply-To: <CAFLszThKqdoRwqSbazWgdw27q9RxJorTwkLmRzZ9FAV48S7gdg@mail.gmail.com>
On Fri, Oct 10, 2025 at 11:35, Simon Glass <sjg@chromium.org> wrote:
> Hi Tom,
>
> On Thu, 9 Oct 2025 at 18:24, Tom Rini <trini@konsulko.com> wrote:
>>
>> On Thu, Oct 09, 2025 at 03:29:53AM -0600, Simon Glass wrote:
>>
>> > The 'bootflow list' command supports looking at the EFI device-path when
>> > available. Move this piece into a common function so it can be used
>> > elsewhere.
>>
>> The point of this was to enable the show_bootflow->bootflow_show chnage,
>> so should be dropped.
>
> OK.
>
>>
>> > Use 'usb' instead of 'usb_mass_storage' for usb so that it fits in the
>> > column space.
>> >
>> > This updates the output from 'bootflow list'.
>>
>> And this is unrelated and should be its own patch. Wikipedia says USB
>> MSC or UMS are the common short forms for USB Mass Storage devices, and
>> we should use one of them to have the output be more precise (since we
>> support USB networking devices for example).
>
> Ok I can move it into its own patch.
>
> Are you wanting this to say 'ums' instead of 'usb' ? Will anyone know
> what that means?
Search for 'ums' gives the following U-Boot documentation:
https://docs.u-boot.org/en/latest/usage/cmd/ums.html#ums-command
Where the acronym is documented.
This is also the acronym used by the cmd (to configure usb gadget as USB
Mass Storage).
So I'd say it's a reasonable acronym
>
> Re the second point, at least in U-Boot a USB Ethernet device shows as
> 'ethernet', i.e. the interface doesn't matter. We don't have logic to
> look a level deeper, at present.
>
> Regards,
> Simon
next prev parent reply other threads:[~2025-10-10 14:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 9:29 [PATCH v4 0/4] boot: Precursor series for global bootmeths Simon Glass
2025-10-09 9:29 ` [PATCH v4 1/4] boot: Improve comments related to " Simon Glass
2025-10-09 12:52 ` Mattijs Korpershoek
2025-10-09 18:34 ` Sam Protsenko
2025-10-09 9:29 ` [PATCH v4 2/4] boot: Move obtaining the label into a common file Simon Glass
2025-10-09 13:13 ` Mattijs Korpershoek
2025-10-09 17:24 ` Tom Rini
2025-10-10 10:35 ` Simon Glass
2025-10-10 14:11 ` Mattijs Korpershoek [this message]
2025-10-10 14:39 ` Tom Rini
2025-10-11 7:21 ` Simon Glass
2025-10-11 16:24 ` Tom Rini
2025-10-09 9:29 ` [PATCH v4 3/4] boot: Add more debugging to iter_incr() Simon Glass
2025-10-09 17:30 ` Tom Rini
2025-10-10 10:36 ` Simon Glass
2025-10-10 14:35 ` Tom Rini
2025-10-11 7:19 ` Simon Glass
2025-10-13 14:15 ` Tom Rini
2025-10-13 15:12 ` Simon Glass
2025-10-13 16:57 ` Tom Rini
2025-10-09 9:29 ` [PATCH v4 4/4] boot: Move preparing bootdev into a function Simon Glass
2025-10-09 17:35 ` Tom Rini
2025-10-10 10:36 ` Simon Glass
2025-10-10 14:38 ` Tom Rini
2025-10-11 7:20 ` Simon Glass
2025-10-11 16:45 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm52vobc.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=andrew.goodbody@linaro.org \
--cc=glaroque@baylibre.com \
--cc=jerome.forissier@linaro.org \
--cc=maximilian.brune@9elements.com \
--cc=moritzf@google.com \
--cc=pbrobinson@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.