All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: tiwai@suse.de, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-motu: drop EPOLLOUT from poll return values as write is not supported
Date: Sat, 30 Aug 2025 09:33:11 +0200	[thread overview]
Message-ID: <87wm6lfemg.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250829233749.366222-1-o-takashi@sakamocchi.jp>

On Sat, 30 Aug 2025 01:37:49 +0200,
Takashi Sakamoto wrote:
> 
> The ALSA HwDep character device of the firewire-motu driver incorrectly
> returns EPOLLOUT in poll(2), even though the driver implements no operation
> for write(2). This misleads userspace applications to believe write() is
> allowed, potentially resulting in unnecessarily wakeups.
> 
> This issue dates back to the driver's initial code added by a commit
> 71c3797779d3 ("ALSA: firewire-motu: add hwdep interface"), and persisted
> when POLLOUT was updated to EPOLLOUT by a commit a9a08845e9ac ('vfs: do
> bulk POLL* -> EPOLL* replacement("").').
> 
> This commit fixes the bug.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied now.


Takashi

      reply	other threads:[~2025-08-30  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 23:37 [PATCH] ALSA: firewire-motu: drop EPOLLOUT from poll return values as write is not supported Takashi Sakamoto
2025-08-30  7:33 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wm6lfemg.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.