From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E7DFCA0EEB for ; Fri, 22 Aug 2025 20:58:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 36C8A10EBB2; Fri, 22 Aug 2025 20:58:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HVnS42v3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D01310EBB2 for ; Fri, 22 Aug 2025 20:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755896315; x=1787432315; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Unkc8U/U438Fmr/krQDcILSi/IVaevlQZ7TvS9bgkak=; b=HVnS42v3mmENrc5vZ3DX8yvgZ8I79PQHFRnd/khFGW2/WNlMDtp7hfe1 JOMfybm3QzrtxZ9MWZDQhQC4Jcw5qcPqsp9+plyYNRmV/zxN1RMmEfGdE ibdYrAEQWXHaYQjZ3CPFGhW9AN/CXI185i5dOo1bjfOOeKyrC9tbJWCkH 5TRu/E9pe2JwLpkWoYWnnwX2YML6D/zcfNSBiVfA9iLDscJprUeXXVEvv LuhFf65Bv5+UEgGfan3TiAgCZvldXOvYvl30Bd/Rvv/zQO5MFg3j/q7fS VvxLhDLE1M+zjkq4AYzXcqJfiqF02YKHYwLXQUqG9b4d4N2IfTS6TjNKC Q==; X-CSE-ConnectionGUID: GYRr2hUhTnCYbQvsXqlzNg== X-CSE-MsgGUID: kq3L5fBuTrK5ASYRxL5SPg== X-IronPort-AV: E=McAfee;i="6800,10657,11529"; a="57918016" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="57918016" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2025 13:58:34 -0700 X-CSE-ConnectionGUID: leT63Qv9R2qCy0Pi466ZUg== X-CSE-MsgGUID: 07WOHv6NTaCp4tiEihlw4g== X-ExtLoop1: 1 Received: from unsofor-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.124.163.28]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2025 13:58:34 -0700 Date: Fri, 22 Aug 2025 13:58:33 -0700 Message-ID: <87wm6vxedi.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Sebinraj, S" Cc: "De Marchi, Lucas" , "intel-xe@lists.freedesktop.org" , "Badrappan, Jeevaka" , Rodrigo Vivi Subject: Re: [PATCH v2] drm/xe: GPU frequency tracing support In-Reply-To: References: <20250811083414.3863103-1-s.sebinraj@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 19 Aug 2025 21:25:43 -0700, Sebinraj, S wrote: > > We went for this addition rather than the one in xe_pmu (via perf stat - user space tool), > as we have a requirement to have the trace point available at d/evens/power/gpu_frequency for Android xTS. > In this case the user won't be triggering the perf subsystem for gpu frequency for gt0, gt1.. even if we add the trace points in xe_pmu. Why not? Which userspace tool is consuming this ftrace and they can't enable the PMU event? The way the ftrace event is implemented here, it really doesn't provide any more information than what is provided by the PMU. IMO, a ftrace might be more acceptable if the freq change event emanated from GuC itself where the freq change is actually implemented. That would need a change to GuC FW, so maybe not an option at present. Also, similar to Rodrigo's comment on the work period series, if we need d/events/power/gpu_frequency (rather than d/events/power/xe_gpu_frequency), that should be added at the drm level rather than at xe level? Would that be acceptable? Thanks. -- Ashutosh