From: Markus Armbruster <armbru@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com,
peter.maydell@linaro.org
Subject: Re: [PATCH 2/2] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
Date: Tue, 29 Jul 2025 14:59:36 +0200 [thread overview]
Message-ID: <87wm7rcfuv.fsf@pond.sub.org> (raw)
In-Reply-To: <87a54ndvnp.fsf@pond.sub.org> (Markus Armbruster's message of "Tue, 29 Jul 2025 14:32:58 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Manos Pitsidianakis <manos.pitsidianakis@linaro.org> writes:
>
>> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster <armbru@redhat.com> wrote:
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index f1bd69c3db..9c22e921e8 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -4432,6 +4432,7 @@ F: docs/requirements.txt
>>> F: docs/sphinx/
>>> F: docs/_templates/
>>> F: docs/devel/docs.rst
>>> +F: docs/devel/qapi-domain.rst
>>
>> Question: Does it matter if this is already covered by QAPI section
>> which has: "F: docs/devel/qapi*"?
>
> I'm adding it to the "Sphinx documentation configuration and build
> machinery" section as well.
>
> Before the patch:
>
> $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst
> Markus Armbruster <armbru@redhat.com> (supporter:QAPI)
> Michael Roth <michael.roth@amd.com> (supporter:QAPI)
> qemu-devel@nongnu.org (open list:All patches CC here)
>
> Afterwards:
>
> $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst
> --> John Snow <jsnow@redhat.com> (maintainer:Sphinx documentat...)
> --> Peter Maydell <peter.maydell@linaro.org> (maintainer:Sphinx documentat...)
> Markus Armbruster <armbru@redhat.com> (supporter:QAPI)
> Michael Roth <michael.roth@amd.com> (supporter:QAPI)
> qemu-devel@nongnu.org (open list:All patches CC here)
>
> Good, because it's John's baby, and he's maintaining it.
>
>> If not,
>>
>> Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>
> Thank you!
>
> [...]
Amending the commit message:
Section QAPI already covers it, and that's fine. It's missing from
"Sphinx documentation configuration and build machinery". Add it
there.
next prev parent reply other threads:[~2025-07-29 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 9:16 [PATCH 0/2] qapi-domain: Typos and MAINTAINERS Markus Armbruster
2025-07-29 9:16 ` [PATCH 1/2] docs/qapi-domain: Fix typos Markus Armbruster
2025-07-29 12:05 ` Manos Pitsidianakis
2025-07-29 9:16 ` [PATCH 2/2] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly Markus Armbruster
2025-07-29 12:09 ` Manos Pitsidianakis
2025-07-29 12:32 ` Markus Armbruster
2025-07-29 12:59 ` Markus Armbruster [this message]
2025-07-29 13:00 ` Philippe Mathieu-Daudé
2025-07-29 13:14 ` [PATCH 0/2] qapi-domain: Typos and MAINTAINERS Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm7rcfuv.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.