From: Collin Funk <collin.funk1@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Chris Down <chris@chrisdown.name>,
"D. Ben Knoble" <ben.knoble@gmail.com>,
git@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] commit: Add commit.signoff configuration option
Date: Wed, 04 Jun 2025 18:46:52 -0700 [thread overview]
Message-ID: <87wm9rklir.fsf@gmail.com> (raw)
In-Reply-To: <xmqq4iwvfx8s.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> Chris Down <chris@chrisdown.name> writes:
>
>> Looking at public dotfiles, many users already work around this with
>> global shell aliases for "commit --signoff". This creates the exact
>> problem
>
> Users conciously using a general customization mechanism to express
> specific intent like the above is one thing. Project giving users a
> tool that is specifically designed to casually set and forget before
> even understanding the implications is another.
>
> So no, anything that specifically targets commit.signoff would not
> fall into the same category as end-users creating aliases for
> themselves to use, I would have to say. And we do not want to give
> an impression that we give tools specifically designed to encourage
> users making casual sign-offs.
I agree.
Although the FSF copyright assignment needed to contribute to some GNU
projects is time-consuming, it forces the contributor to consider "Do I
own the rights to the code I create?" This isn't the case in many US
states if you are an exempt employee, which most Software Developers
are.
Similarly, when you sign-off to the DCO you also acknowledge that you
have the rights to license your work under the projects license. By
adding this option, I worry that contributors will just configure it
globally as a prerequisite to their work being accepted, and not
consider whether they are even allowed to make the contribution in the
first place.
Collin
next prev parent reply other threads:[~2025-06-05 1:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 12:20 [PATCH] commit: Add commit.signoff configuration option Chris Down
2025-05-13 13:12 ` Kristoffer Haugsbakk
2025-05-13 21:09 ` D. Ben Knoble
2025-05-14 16:46 ` Chris Down
2025-05-15 0:17 ` Junio C Hamano
2025-05-15 13:22 ` Chris Down
2025-05-16 13:09 ` Junio C Hamano
2025-05-16 15:04 ` Chris Down
2025-06-03 6:54 ` Chris Down
2025-06-04 13:32 ` Junio C Hamano
2025-06-05 1:46 ` Collin Funk [this message]
2025-06-09 4:24 ` Chris Down
2025-05-16 11:50 ` Ben Knoble
2025-05-16 14:28 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm9rklir.fsf@gmail.com \
--to=collin.funk1@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=chris@chrisdown.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.