Re: [Buildroot] [PATCH 2/3] toolchain/wrapper: check we did not add more args than expected

From: Peter Korsgaard <peter@korsgaard.com>
To: <yann.morin@orange.com>
Cc: <buildroot@buildroot.org>,  Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 2/3] toolchain/wrapper: check we did not add more args than expected
Date: Sun, 18 May 2025 14:51:24 +0200	[thread overview]
Message-ID: <87wmaeqdyr.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <e4024c6c1e1825bd52ab14faafbc7655d3074eb3.1723543467.git.yann.morin@orange.com> (yann morin's message of "Tue, 13 Aug 2024 12:04:30 +0200")

>>>>>   <yann.morin@orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin@orange.com>
 > We have a hard-coded constant that defines how many expected args we may
 > conditionally add at most, but it is very easy to miss updating that
 > when adding new conditional args.

 > Add a check that we did not overshoot the allowance.

 > Ideally, we would have a nice way to add to, and extend the *args array
 > dynamically, but this would be quite costly, while the wrapper is a hot
 > path to the compiler. So, this test is a better solution in the end: it
 > is simple and cheap.

Costly? It would just be a realloc call, and the list of argument
pointers is not very long, so I doubt it would be noticable compared to
all the argument parsing and finally running the real compiler.

In fact, I think it would make more sense to get rid of our
EXCLUSIVE_ARGS constant and just allocate room for E.G. 1024 arguments
and then just realloc in the special cases where that is not enough.

I've sent a small series doing that here:

https://patchwork.ozlabs.org/project/buildroot/patch/20250518124949.4159568-2-peter@korsgaard.com/

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot