Re: Bad topology file paths when re-inserting snd_sof_pci_intel_tgl

[Takashi Iwai <tiwai@suse.de>]

On Tue, 22 Apr 2025 20:48:40 +0200,
Tavian Barnes wrote:
> 
> I'm trying to debug some audio issues on my ThinkPad X1 Carbon (Gen
> 10), and I noticed something that's probably a bug: when I remove and
> re-insert the snd_sof_pci_intel_tgl module, it tries to load a
> different tplg file every time.  Example:
> 
> # dmesg -t | grep tplg
> sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file:
> intel/sof-tplg/sof-hda-generic-idisp-4ch.tplg
> # modprobe -r snd_sof_pci_intel_tgl
> # modprobe snd_sof_pci_intel_tgl
> # dmesg | grep tplg
> sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file:
> intel/sof-tplg/sof-hda-generic-idisp-4ch.tplg
> sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file:
> intel/sof-tplg/sof-hda-generic-idisp-idisp-4ch.tplg
> # modprobe -r snd_sof_pci_intel_tgl
> # modprobe snd_sof_pci_intel_tgl
> # dmesg | grep tplg
> sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file:
> intel/sof-tplg/sof-hda-generic-idisp-4ch.tplg
> sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file:
> intel/sof-tplg/sof-hda-generic-idisp-idisp-4ch.tplg
> sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file:
> intel/sof-tplg/\xa0\x11\xaf\x0e\x8d\x8e\xff\xff\xb0\x11\xaf\x0e\x8d\x8e\xff\xff\xb0\x11\xaf\x0e\x8d\x8e\xff\xff-idisp-4ch.tplg
> 
> The second time, it added an extra -idisp to the path
> (intel/sof-tplg/sof-hda-generic-idisp-idisp-4ch.tplg).  The third
> time, the path seems to have become totally corrupted.
> 
> I'm seeing this on kernel version 6.14.3-arch1, which has no
> sound-related changes from the regular stable 6.14.3 kernel.  I can
> try current master but I don't see any relevant changes to the code
> that adds -idisp in sound/soc/sof/intel/hda.c.

Looks like a bug introduced by the commit
5458411d75947a4212e50a401ec0a98d4c6c931b
    ASoC: SOF: Intel: hda: refactoring topology name fixup for HDA mach
It overwrites hda_mach->sof_tplg_filename with a string of
devm_kasprintf().


thanks,

Takashi