From: Takashi Iwai <tiwai@suse.de>
To: "Geoffrey D. Bennett" <g@b4.vu>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add retry on -EPROTO from usb_set_interface()
Date: Sun, 20 Apr 2025 10:39:20 +0200 [thread overview]
Message-ID: <87wmbftefb.wl-tiwai@suse.de> (raw)
In-Reply-To: <Z//7s9dKsmVxHzY2@m.b4.vu>
On Wed, 16 Apr 2025 20:49:23 +0200,
Geoffrey D. Bennett wrote:
>
> During initialisation of Focusrite USB audio interfaces, -EPROTO is
> sometimes returned from usb_set_interface(), which sometimes prevents
> the device from working: subsequent usb_set_interface() and
> uac_clock_source_is_valid() calls fail.
>
> This patch adds up to 5 retries in endpoint_set_interface(), with a
> delay starting at 5ms and doubling each time. 5 retries was chosen to
> allow for longer than expected waits for the interface to start
> responding correctly; in testing, a single 5ms delay was sufficient to
> fix the issue.
>
> Closes: https://github.com/geoffreybennett/fcp-support/issues/2
> Cc: stable@vger.kernel.org
> Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-04-20 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 18:49 [PATCH] ALSA: usb-audio: Add retry on -EPROTO from usb_set_interface() Geoffrey D. Bennett
2025-04-20 8:39 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmbftefb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=g@b4.vu \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.