From: "Alex Bennée" <alex.bennee@linaro.org>
To: Mads Ynddal <mads@ynddal.dk>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Phil Dennis-Jordan <phil@philjordan.eu>,
Cameron Esfahani <dirty@apple.com>,
Roman Bolshakov <rbolshakov@ddn.com>,
Peter Maydell <peter.maydell@linaro.org>,
Alexander Graf <agraf@csgraf.de>,
Mads Ynddal <m.ynddal@samsung.com>,
Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH 1/2] hvf: avoid repeatedly setting trap debug for each cpu
Date: Mon, 14 Apr 2025 10:20:22 +0100 [thread overview]
Message-ID: <87wmbndrqh.fsf@draig.linaro.org> (raw)
In-Reply-To: <20250402135229.28143-2-mads@ynddal.dk> (Mads Ynddal's message of "Wed, 2 Apr 2025 15:52:28 +0200")
Mads Ynddal <mads@ynddal.dk> writes:
> From: Mads Ynddal <m.ynddal@samsung.com>
>
> hvf_arch_set_traps is already called from a context of a specific
> CPUState, so we don't need to do a nested CPU_FOREACH.
>
> It also results in an error from hv_vcpu_set_sys_reg, as it may only be
> called from the thread owning the vCPU.
>
> Tested-by: Daniel Gomez <da.gomez@samsung.com>
> Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Looks reasonable to me:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-04-14 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 13:52 [PATCH 0/2] Fix GDB support for macOS hvf Mads Ynddal
2025-04-02 13:52 ` [PATCH 1/2] hvf: avoid repeatedly setting trap debug for each cpu Mads Ynddal
2025-04-02 18:15 ` Daniel Gomez
2025-04-14 9:20 ` Alex Bennée [this message]
2025-04-02 13:52 ` [PATCH 2/2] hvf: only update sysreg from owning thread Mads Ynddal
2025-04-14 9:11 ` Alex Bennée
2025-05-02 12:55 ` Peter Maydell
2025-04-14 8:07 ` [PATCH 0/2] Fix GDB support for macOS hvf Mads Ynddal
2025-05-02 12:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmbndrqh.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@csgraf.de \
--cc=da.gomez@samsung.com \
--cc=dirty@apple.com \
--cc=m.ynddal@samsung.com \
--cc=mads@ynddal.dk \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.