Re: [PATCH v3 01/16] drm/mst: remove mgr parameter and debug logging from drm_dp_get_vc_payload_bw()

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 07 Jan 2025, Maxime Ripard <mripard@kernel.org> wrote:
> On Tue, Jan 07, 2025 at 11:55:42AM +0200, Jani Nikula wrote:
>> On Fri, 03 Jan 2025, Jani Nikula <jani.nikula@intel.com> wrote:
>> > The struct drm_dp_mst_topology_mgr *mgr parameter is only used for debug
>> > logging in case the passed in link rate or lane count are zero. There's
>> > no further error checking as such, and the function returns 0.
>> >
>> > There should be no case where the parameters are zero. The returned
>> > value is generally used as a divisor, and if we were hitting this, we'd
>> > be seeing division by zero.
>> >
>> > Just remove the debug logging altogether, along with the mgr parameter,
>> > so that the function can be used in non-MST contexts without the
>> > topology manager.
>> >
>> > v2: Also remove drm_dp_mst_helper_tests_init as unnecessary (Imre)
>> >
>> > Cc: Imre Deak <imre.deak@intel.com>
>> > Cc: Lyude Paul <lyude@redhat.com>
>> > Reviewed-by: Imre Deak <imre.deak@intel.com>
>> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> Maarten, Maxime, Thomas, ack for merging this via drm-intel along with
>> the rest of the series?
>
> Ack

Thanks, pushed via drm-intel-next with Maxime's ack and Thomas' IRC ack.

BR,
Jani.

-- 
Jani Nikula, Intel