From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] wifi: ath12k: Refactor Rx status TLV parsing procedure argument
Date: Thu, 19 Dec 2024 20:54:38 +0200 [thread overview]
Message-ID: <87wmfvfqq9.fsf@kernel.org> (raw)
In-Reply-To: <44bfd319-caf2-7459-f62e-0f61de452a84@quicinc.com> (Karthikeyan Periyasamy's message of "Thu, 19 Dec 2024 17:12:26 +0530")
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> On 12/19/2024 5:04 PM, Kalle Valo wrote:
>> Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
>>
>>> Currently, ath12k_dp_mon_rx_parse_status_tlv() takes the TLV tag, TLV data
>>> and TLV userid as separate arguments from the caller. These argument can
>>> be fetched from the TLV header itself. Therefore, pass the TLV header and
>>> retrieve the necessary fields from the header instead of passing them from
>>> the caller.
>> The commit message doesn't reply to "why?". Is there a clear benefit
>> in
>> the future or are you just doing random code cleanup?
>>
>
> It benefit in the future for supporting EHT monitor functionality.
How does it help exactly? Having even just one sentence explaining the
motivation in the commit message would help a lot. Otherwise these just
look random changes.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-12-19 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 0:10 [PATCH 0/3] wifi: ath12k: Refactor monitor Rx handler Karthikeyan Periyasamy
2024-12-19 0:10 ` [PATCH 1/3] wifi: ath12k: Refactor the monitor Rx parser handler argument Karthikeyan Periyasamy
2024-12-19 11:27 ` Kalle Valo
2024-12-19 0:10 ` [PATCH 2/3] wifi: ath12k: Refactor the monitor Tx/RX handler procedure arguments Karthikeyan Periyasamy
2024-12-19 11:32 ` Kalle Valo
2024-12-19 11:35 ` Kalle Valo
2024-12-19 0:10 ` [PATCH 3/3] wifi: ath12k: Refactor Rx status TLV parsing procedure argument Karthikeyan Periyasamy
2024-12-19 11:34 ` Kalle Valo
2024-12-19 11:42 ` Karthikeyan Periyasamy
2024-12-19 18:54 ` Kalle Valo [this message]
2024-12-20 0:26 ` Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmfvfqq9.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.