From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Tamir Duberstein" <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/6] rust: reorder `ForeignOwnable` items
Date: Tue, 12 Nov 2024 11:10:57 +0100 [thread overview]
Message-ID: <87wmh8rccu.fsf@kernel.org> (raw)
In-Reply-To: <20241110-borrow-mut-v4-5-053976068215@gmail.com> (Tamir Duberstein's message of "Sun, 10 Nov 2024 09:14:06 -0500")
"Tamir Duberstein" <tamird@gmail.com> writes:
> `{into,from}_foreign` before `borrow` is slightly more logical.
>
> This removes an inconsistency with `kbox.rs` which already uses this
> ordering.
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2024-11-12 10:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 14:14 [PATCH v4 0/6] rust: add improved version of `ForeignOwnable::borrow_mut` Tamir Duberstein
2024-11-10 14:14 ` [PATCH v4 1/6] rust: arc: use `NonNull::new_unchecked` Tamir Duberstein
2024-11-12 10:08 ` Andreas Hindborg
2024-11-10 14:14 ` [PATCH v4 2/6] rust: types: avoid `as` casts Tamir Duberstein
2024-11-12 10:09 ` Andreas Hindborg
2024-11-10 14:14 ` [PATCH v4 3/6] rust: arc: split unsafe block, add missing comment Tamir Duberstein
2024-11-12 10:09 ` Andreas Hindborg
2024-11-10 14:14 ` [PATCH v4 4/6] rust: change `ForeignOwnable` pointer to mut Tamir Duberstein
2024-11-10 14:14 ` [PATCH v4 5/6] rust: reorder `ForeignOwnable` items Tamir Duberstein
2024-11-12 10:10 ` Andreas Hindborg [this message]
2024-11-10 14:14 ` [PATCH v4 6/6] rust: add improved version of `ForeignOwnable::borrow_mut` Tamir Duberstein
2024-11-11 15:31 ` Tamir Duberstein
2024-11-11 15:55 ` Alice Ryhl
2024-11-11 16:21 ` Tamir Duberstein
2024-11-12 0:02 ` Miguel Ojeda
2024-11-12 15:20 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmh8rccu.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.