All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3] drm: Print bad EDID notices less often
Date: Fri, 27 Sep 2024 15:23:11 +0300	[thread overview]
Message-ID: <87wmixxp3k.fsf@intel.com> (raw)
In-Reply-To: <ZvaX-0wBGiHd8YHS@tassilo>

On Fri, 27 Sep 2024, Andi Kleen <ak@linux.intel.com> wrote:
> On Fri, Sep 27, 2024 at 12:30:04PM +0300, Jani Nikula wrote:
>> On Thu, 26 Sep 2024, Andi Kleen <ak@linux.intel.com> wrote:
>> > I have an old monitor that reports a zero EDID block, which results in a
>> > warning message. This happens on every screen save cycle, and maybe in
>> > some other situations, and over time the whole kernel log gets filled
>> > with these redundant messages.
>> >
>> > Make most of these prints conditional on bad_edid_count like other verbose EDID
>> > messages.
>> 
>> Honestly I think merging this would be counter-productive to addressing
>> the issue properly.
>
> You think it's a problem on the host side, not the monitor side?

Both. :)

Having zero EDID block is an issue with the display, logging excessively
about it is an issue on the host side.

>> Please just give me the chance to look into it.
>> 
>> Is your zero EDID block the base block or an extension block?
>
> It's an extension block I believe.

Now that should be helpful in detecting display changes, and only
logging once per display. Unless you unplug and plug, but that's not so
common.

BR,
Jani.


-- 
Jani Nikula, Intel

      reply	other threads:[~2024-09-27 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26 18:01 [PATCH v3] drm: Print bad EDID notices less often Andi Kleen
2024-09-27  9:30 ` Jani Nikula
2024-09-27 11:33   ` Andi Kleen
2024-09-27 12:23     ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmixxp3k.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.