All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Nick Chan <towinchenmi@gmail.com>,
	Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht, Nick Chan <towinchenmi@gmail.com>
Subject: Re: [PATCH RESEND 3/3] irqchip/apple-aic: Add a new "Global fast IPIs only" feature level
Date: Thu, 29 Aug 2024 15:12:36 +0200	[thread overview]
Message-ID: <87wmjza2wr.ffs@tglx> (raw)
In-Reply-To: <20240829110436.46052-4-towinchenmi@gmail.com>

On Thu, Aug 29 2024 at 19:02, Nick Chan wrote:
>  
> +	if (irqc->info.local_fast_ipi)
> +		static_branch_enable(&use_local_fast_ipi);
> +	else
> +		static_branch_disable(&use_local_fast_ipi);

As you define the key to be true by default there is no point to enable
the branch some more. Copy & pasta ...

Thanks,

        tglx



  reply	other threads:[~2024-08-29 13:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 11:02 [PATCH RESEND 0/3] Add AIC support for A7-A11 SoCs Nick Chan
2024-08-29 11:02 ` [PATCH RESEND 1/3] dt-bindings: apple,aic: Document A7-A11 compatibles Nick Chan
2024-08-29 11:46   ` Krzysztof Kozlowski
2024-08-29 12:00     ` Nick Chan
2024-08-29 12:37       ` Krzysztof Kozlowski
2024-08-29 11:02 ` [PATCH RESEND 2/3] irqchip/apple-aic: Only access IPI sysregs when use_fast_ipi is true Nick Chan
2024-08-29 13:08   ` Thomas Gleixner
2024-08-29 13:48     ` Nick Chan
2024-08-29 11:02 ` [PATCH RESEND 3/3] irqchip/apple-aic: Add a new "Global fast IPIs only" feature level Nick Chan
2024-08-29 13:12   ` Thomas Gleixner [this message]
2024-08-29 14:06   ` Nick Chan
2024-08-29 11:47 ` [PATCH RESEND 0/3] Add AIC support for A7-A11 SoCs Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmjza2wr.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=robh@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=towinchenmi@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.