From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
Lukasz Majewski <lukma@denx.de>, Marek Vasut <marex@denx.de>,
Zixun LI <admin@hifiphile.com>
Cc: u-boot@lists.denx.de, tools@linux.kernel.org
Subject: Re: [PATCH] cmd: bind: Use device sequence instead for driver bind/unbind
Date: Tue, 20 Aug 2024 09:39:34 +0200 [thread overview]
Message-ID: <87wmkbve15.fsf@baylibre.com> (raw)
In-Reply-To: <172413500327.69624.5444644456831665790.b4-ty@baylibre.com>
On mar., août 20, 2024 at 08:23, Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote:
> Hi,
>
> On Fri, 02 Aug 2024 11:28:13 +0200, Zixun LI wrote:
>> Currently uclass index is used for bind/unbind which ignores alias
>> sequence numbering. Use device sequence number instead as it's
>> the number explicitly set in the DT.
>>
>> Also update documentation to use sequence number.
>>
>>
>> [...]
>
> Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu-next)
>
> [1/1] cmd: bind: Use device sequence instead for driver bind/unbind
> https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/0c48507eee08b5e7d4e8484727efe47cfabff0ee
Somehow, b4 did the wrong thing here when running:
$ b4 shazam -s -l --check 20240802092820.917450-1-admin@hifiphile.com
Grabbing thread from lore.kernel.org/all/20240802092820.917450-1-admin@hifiphile.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 12 messages in the thread
Assuming new revision: v2 ([PATCH] dm: core: Show device sequence instead in dm_dump_tree())
Assuming new revision: v3 ([PATCH] cmd: bind: Use device sequence instead for driver bind/unbind)
Analyzing 0 code-review messages
Will use the latest revision: v3
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
✗ [PATCH] cmd: bind: Use device sequence instead for driver bind/unbind
+ Reviewed-by: Simon Glass <sjg@chromium.org> (✗ DKIM/chromium.org)
+ Link: https://lore.kernel.org/r/20240802092820.917450-3-admin@hifiphile.com
+ Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
● checkpatch.pl: passed all checks
---
✗ BADSIG: DKIM/hifiphile-com.20230601.gappssmtp.com
---
Total patches: 1
---
Applying: cmd: bind: Use device sequence instead for driver bind/unbind
It applied:
https://patchwork.ozlabs.org/project/uboot/patch/20240802092820.917450-3-admin@hifiphile.com/
Instead of:
https://patchwork.ozlabs.org/project/uboot/patch/20240802092820.917450-1-admin@hifiphile.com/
I have fixed this up manually, see:
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/73f5b54a589cb6ff97aaca55e7c97d68b43997ee
>
> --
> Mattijs
next prev parent reply other threads:[~2024-08-20 7:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 9:28 [PATCH] usb: gadget: udc: Fix duplicate uclass name Zixun LI
2024-08-02 9:28 ` [PATCH] dm: core: Show device sequence instead in dm_dump_tree() Zixun LI
2024-08-06 21:50 ` Simon Glass
2024-08-27 23:22 ` Tom Rini
2024-08-02 9:28 ` [PATCH] cmd: bind: Use device sequence instead for driver bind/unbind Zixun LI
2024-08-06 21:50 ` Simon Glass
2024-08-20 6:23 ` Mattijs Korpershoek
2024-08-20 7:39 ` Mattijs Korpershoek [this message]
2024-08-27 23:22 ` Tom Rini
2024-08-06 21:50 ` [PATCH] usb: gadget: udc: Fix duplicate uclass name Simon Glass
2024-08-07 7:07 ` Mattijs Korpershoek
2024-08-07 12:36 ` Zixun LI
2024-08-13 8:28 ` Mattijs Korpershoek
2024-08-13 13:39 ` Zixun LI
2024-08-16 15:37 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmkbve15.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=admin@hifiphile.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=sjg@chromium.org \
--cc=tools@linux.kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.