From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:3f8c:b0:1be9:327d:8ee3 with SMTP id bm12csp187107njb; Tue, 30 Jul 2024 23:37:59 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWZEbmdzZueTVaJcddHejzPoM5ei1a2OpmjXBYGTgoqDSVk82kfowK9Tq1bJeRmXUu7bJZQcq0yKWgtWuNs61FxGK+qI3LU X-Google-Smtp-Source: AGHT+IEqIuKJrpO0CYoWNYK2WWwefjJltKHZekfXCNgqiwsI/uq+ZZZxZf5ScWpl3hquFpinFdeg X-Received: by 2002:ad4:5f4b:0:b0:6b5:e6b3:72fd with SMTP id 6a1803df08f44-6bb55a4d287mr163518716d6.29.1722407879074; Tue, 30 Jul 2024 23:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1722407879; cv=none; d=google.com; s=arc-20160816; b=gt42+t3DsLO0N9eBJ18ucvK2oEv1NYcuvsqRVgKV4xoprvYp47hh26R595IFuSd2ut 0n720UgWZzTDLx2xcurlXuxoKD+lTbiDKTaciL45YLTVh8dEMW9Z6bPdqPYqaiXSrOtA B9zl5s5sFW6eOHBNoTnxl1QqJlUl7bsEJEzaVHYblI0pSjiWpIUZpyQJc85JORDBpzBt qtlFEvHkMP2tNBqSn5ZEI51qiYgokDcIlQeoqa5lx3N9AR9dw2eSZFbDniu2MR9fRfhA S3Fe2w9VRg9LD+kda46ngP8zDWsBs80PnShCKgUZcOHdL/vx6liwEuMYPZ9Clxlfd2VO 1u3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:dkim-signature; bh=wnUTEtS+No9S/JuqPITES1G3oDrohvDkWf9tXSxF6fE=; fh=BFXneFjqdmejipxZONeQdOrAwPaPLkMKfOeOm8r0t5U=; b=rdZ2dTJvyJxKf4SlPGkZlSSnbJ7eq2ZcIS8z9+6mC5aGP/KrO8jEmWHJJc39me3pTl Fv9M6GFnYXEJi8UOmqti5CFcFA78ONHMwiyJzGLIptuJsueLAwN3tG9u3OVzpfqWLoh1 7n4fNR2YmhvgnG3bhWGMwRC5zI2zdAUE/kA9kHTFm/GuWKj3I0SVHqopQ0rBB+GnZk0V qysz1/kUwHjWu7urfBb5aL1djRNHxKpB5BI43Dx/COhHqFufUxTywt0hWcQ6La2NDK+q e99h7+7f9O5FkU70deCV9MsqADXhMzR8UjqIgi+LdhkNjuwU2dn87bMaze+IYUT4dT2E Eu7A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="FKx/PlCv"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6bb3fa867e4si144708686d6.258.2024.07.30.23.37.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2024 23:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="FKx/PlCv"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZ2xz-0002oE-VK; Wed, 31 Jul 2024 02:37:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZ2xy-0002hS-79 for qemu-arm@nongnu.org; Wed, 31 Jul 2024 02:37:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZ2xv-0006cW-GG for qemu-arm@nongnu.org; Wed, 31 Jul 2024 02:37:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722407858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wnUTEtS+No9S/JuqPITES1G3oDrohvDkWf9tXSxF6fE=; b=FKx/PlCvHa5bQctYF7tReIPWefKPZID4lH4DGVpLRYcpL8+B3xPDlli5meaOncXyhr/OFb y2HOY7uL4RtHURLjwdx4x2CjX8Wfw59Fk6U6XekPLhSjev+742x0xZ6be9ExkN35v7WMbo xcyarc7Qgh4icF0lWYE2LsgBEthEcAY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-uE_kmhtRPSqnjMjlJ6wdWA-1; Wed, 31 Jul 2024 02:37:30 -0400 X-MC-Unique: uE_kmhtRPSqnjMjlJ6wdWA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EF29B1955D52; Wed, 31 Jul 2024 06:37:16 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.65]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7061D19560B2; Wed, 31 Jul 2024 06:37:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4172521E668B; Wed, 31 Jul 2024 08:37:11 +0200 (CEST) From: Markus Armbruster To: Avihai Horon Cc: Daniel P. =?utf-8?Q?Berrang=C3=A9?= , qemu-devel@nongnu.org, alex.williamson@redhat.com, andrew@codeconstruct.com.au, andrew@daynix.com, arei.gonglei@huawei.com, berto@igalia.com, borntraeger@linux.ibm.com, clg@kaod.org, david@redhat.com, den@openvz.org, eblake@redhat.com, eduardo@habkost.net, farman@linux.ibm.com, farosas@suse.de, hreitz@redhat.com, idryomov@gmail.com, iii@linux.ibm.com, jamin_lin@aspeedtech.com, jasowang@redhat.com, joel@jms.id.au, jsnow@redhat.com, kwolf@redhat.com, leetroy@gmail.com, marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com, michael.roth@amd.com, mst@redhat.com, mtosatti@redhat.com, nsg@linux.ibm.com, pasic@linux.ibm.com, pbonzini@redhat.com, peter.maydell@linaro.org, peterx@redhat.com, philmd@linaro.org, pizhenwei@bytedance.com, pl@dlhnet.de, richard.henderson@linaro.org, stefanha@redhat.com, steven_lee@aspeedtech.com, thuth@redhat.com, vsementsov@yandex-team.ru, wangyanan55@huawei.com, yuri.benditovich@daynix.com, zhao1.liu@intel.com, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-s390x@nongnu.org, kvm@vger.kernel.org, =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH 01/18] qapi: Smarter camel_to_upper() to reduce need for 'prefix' In-Reply-To: <462d7540-f9ad-4380-8056-232e69f161e9@nvidia.com> (Avihai Horon's message of "Wed, 31 Jul 2024 08:59:28 +0300") References: <20240730081032.1246748-1-armbru@redhat.com> <20240730081032.1246748-2-armbru@redhat.com> <87mslzgjde.fsf@pond.sub.org> <9b147a34-4641-4b4c-a050-51ceb3ea6a67@nvidia.com> <87jzh2kuux.fsf@pond.sub.org> <462d7540-f9ad-4380-8056-232e69f161e9@nvidia.com> Date: Wed, 31 Jul 2024 08:37:11 +0200 Message-ID: <87wml2jcdk.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: 7F84HrzCakfc Avihai Horon writes: > On 31/07/2024 8:12, Markus Armbruster wrote: >> External email: Use caution opening links or attachments >> >> >> Avihai Horon writes: >> >>> On 30/07/2024 15:22, Markus Armbruster wrote: >>>> Avihai, there's a question for you on VfioMigrationState. >>>> >>>> Daniel P. Berrang=C3=A9 writes: >>>> >>>>> On Tue, Jul 30, 2024 at 10:10:15AM +0200, Markus Armbruster wrote: >> [...] >> >>>> * VfioMigrationState >>>> >>>> Can't see why this one has a prefix. Avihai, can you enlighten me? >>> >>> linux-headers/linux/vfio.h defines enum vfio_device_mig_state with valu= es VFIO_DEVICE_STATE_STOP etc. >> >> It does not define any VFIO_DEVICE_STATE_*, though. >> >>> I used the QAPI prefix to emphasize this is a QAPI entity rather than a= VFIO entity. >> >> We define about two dozen symbols starting with VFIO_, and several >> hundreds starting with vfio_. What makes this enumeration type >> different so its members need emphasis? > > Right. I thought it would be clearer with the QAPI prefix because VFIO_DE= VICE_STATE_* and VFIO_MIGRATION_STATE_* have similar values. > > But it's not a must. If you want to reduce prefix usage, go ahead, I don'= t have a strong opinion about it. Thanks!