From: Kalle Valo <kvalo@kernel.org>
To: Aleksandr Mishin <amishin@t-argos.ru>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
<linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lvc-project@linuxtesting.org>
Subject: Re: [PATCH net] wifi: rtw89: Fix array index mistake in rtw89_sta_info_get_iter()
Date: Thu, 04 Jul 2024 12:53:14 +0300 [thread overview]
Message-ID: <87wmm1cwl1.fsf@kernel.org> (raw)
In-Reply-To: <20240703210510.11089-1-amishin@t-argos.ru> (Aleksandr Mishin's message of "Thu, 4 Jul 2024 00:05:10 +0300")
Aleksandr Mishin <amishin@t-argos.ru> writes:
> In rtw89_sta_info_get_iter() 'status->he_gi' is compared to array size.
> But then 'rate->he_gi' is used as array index instead of 'status->he_gi'.
> This can lead to go beyond array boundaries in case of 'rate->he_gi' is
> not equal to 'status->he_gi' and is bigger than array size. Looks like
> "copy-paste" mistake.
>
> Fix this mistake by replacing 'rate->he_gi' with 'status->he_gi'.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
A reminder for maintainers: rtw89 patches go to Ping's rtw tree, not net
tree.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-07-04 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:05 [PATCH net] wifi: rtw89: Fix array index mistake in rtw89_sta_info_get_iter() Aleksandr Mishin
2024-07-04 9:53 ` Kalle Valo [this message]
2024-07-05 2:04 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmm1cwl1.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=amishin@t-argos.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.