All of lore.kernel.org
 help / color / mirror / Atom feed
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Lukasz Majewski <lukma@denx.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Sean Anderson <seanga2@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v3 2/4] clk: qcom: clear div mask before assigning a new divider
Date: Tue, 12 Mar 2024 20:00:17 +0000	[thread overview]
Message-ID: <87wmq7z0dr.fsf@epam.com> (raw)
In-Reply-To: <CAFA6WYNTH+GVzm3dqcfUjRd94fAtO6vDj2+8PyjuApmj0_qffg@mail.gmail.com>


Hi Sumit,

Thank you for the review.

Sumit Garg <sumit.garg@linaro.org> writes:

> On Tue, 12 Mar 2024 at 03:03, Volodymyr Babchuk
> <Volodymyr_Babchuk@epam.com> wrote:
>>
>> The current behaviour does a bitwise OR of the previous and new
>> divider values, this is wrong as some bits maybe be set already. We
>
> nit: s/maybe be/maybe/
>

Oops, right. Can this be applied by the committer during the merge
process? I know that committers in other open source project do this
sometimes. Or should I post a new version?

[...]

-- 
WBR, Volodymyr

  reply	other threads:[~2024-03-12 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 21:33 [PATCH v3 0/4] Volodymyr Babchuk
2024-03-11 21:33 ` [PATCH v3 1/4] qcom: board: validate fdt before trying to use it Volodymyr Babchuk
2024-03-12 18:02   ` Caleb Connolly
2024-03-11 21:33 ` [PATCH v3 2/4] clk: qcom: clear div mask before assigning a new divider Volodymyr Babchuk
2024-03-12  8:29   ` Sumit Garg
2024-03-12 20:00     ` Volodymyr Babchuk [this message]
2024-03-11 21:33 ` [PATCH v3 3/4] clk: qcom: add support for power domains uclass Volodymyr Babchuk
2024-03-12  8:31   ` Sumit Garg
2024-03-12 18:01   ` Caleb Connolly
2024-03-13 17:12   ` Caleb Connolly
2024-03-13 17:15   ` Caleb Connolly
2024-03-11 21:33 ` [PATCH v3 4/4] pinctrl: qcom: pass pin number to get_function_mux callback Volodymyr Babchuk
2024-03-19 12:39 ` [PATCH v3 0/4] Caleb Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmq7z0dr.fsf@epam.com \
    --to=volodymyr_babchuk@epam.com \
    --cc=caleb.connolly@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=lukma@denx.de \
    --cc=neil.armstrong@linaro.org \
    --cc=seanga2@gmail.com \
    --cc=sumit.garg@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.