From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Prabhu Sannachi <prabhu.sannachi@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads
Date: Sun, 25 Feb 2024 08:53:00 +0100 [thread overview]
Message-ID: <87wmqtrndv.fsf@48ers.dk> (raw)
In-Reply-To: <20240224214601.680607-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sat, 24 Feb 2024 22:46:01 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> redis-plus-plus unconditonally uses mutex and so needs threads since its
> addition in commit c46df9de21e718a9ed6a2df2bb945c386695d3bf and
> https://github.com/sewenew/redis-plus-plus/commit/1fa8f6bbfb24c8f328aa23ee1dd3c3f99c1b4caf:
> In file included from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.h:27,
> from /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/connection_pool.cpp:17:
> /home/autobuild/autobuild/instance-5/output-1/build/redis-plus-plus-1.3.10/src/sw/redis++/sentinel.h:95:10: error: 'mutex' in namespace 'std' does not name a type
> 95 | std::mutex _mutex;
> | ^~~~~
> Fixes: c46df9de21e718a9ed6a2df2bb945c386695d3bf
> - http://autobuild.buildroot.org/results/cc4c54134e8a522b4c028aab4266f47cf862e2a9
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-25 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 21:46 [Buildroot] [PATCH 1/1] package/redis-plus-plus: needs threads Fabrice Fontaine
2024-02-25 7:53 ` Peter Korsgaard [this message]
2024-03-17 19:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmqtrndv.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=prabhu.sannachi@collins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.