Re: [PATCH 3/4] wifi: rtw89: fw: parse secure section from firmware file

[Kalle Valo <kvalo@kernel.org>]

Ping-Ke Shih <pkshih@realtek.com> writes:

> On Sun, 2024-02-04 at 03:22 +0800, kernel test robot wrote:
>> 
>>    drivers/net/wireless/realtek/rtw89/fw.c: In function 'rtw89_fw_hdr_parser_v1':
>> > > drivers/net/wireless/realtek/rtw89/fw.c:384:88: warning: format
>> > > '%lx' expects argument of type
>> > > 'long unsigned int', but argument 9 has type 'int' [-Wformat=]
>>      384 | "section[%d] type=%d len=0x%-6x mssc=%d mssc_len=%d
>> addr=%lx\n",
>>          |                                                                                      ~~
>> ^
>>          |
>> |
>>          |
>> long unsigned int
>>          |                                                                                      %x
>>      385 |                             i, section_info->type, section_info->len,
>>      386 |                             section_info->mssc, mssc_len, bin - fw);
>>          |                                                           ~~~~~~~~
>>          |                                                               |
>>          |                                                               int
>
> I looked for how to print out differences (subtraction) of points, and
> "%tx" is the desired format [1]. I corrected this by v2.
>
> [1] https://docs.kernel.org/core-api/printk-formats.html#pointer-differences

Heh, never heard of %td and %tx before. Thanks for teaching us :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches