Re: [Buildroot] [PATCH 1/1] package/apcupsd: set LD to TARGET_CXX

From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/apcupsd: set LD to TARGET_CXX
Date: Sun, 14 Jan 2024 22:35:37 +0100	[thread overview]
Message-ID: <87wmsbk386.fsf@48ers.dk> (raw)
In-Reply-To: <20240113100654.85904-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sat, 13 Jan 2024 11:06:54 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > As found out by Yann E. Morin in [1], apcupsd configure script is ugly,
 > and uses gcc to do the link line-wrapping which will raise the following
 > build failure with gcc 13:

 > /home/buildroot/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc64le-buildroot-linux-gnu/13.2.0/../../../../powerpc64le-buildroot-linux-gnu/bin/ld:
 > /home/buildroot/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc64le-buildroot-linux-gnu/13.2.0/../../../../powerpc64le-buildroot-linux-gnu/lib/../lib64/libsupc++.a(eh_alloc.o):
 > in function `std::basic_string_view<char, std::char_traits<char>
 >> ::compare(unsigned long, unsigned long, char const*, unsigned long)
 > const':
 > eh_alloc.cc:(.text._ZNKSt17basic_string_viewIcSt11char_traitsIcEE7compareEmmPKcm[_ZNKSt17basic_string_viewIcSt11char_traitsIcEE7compareEmmPKcm]+0x44):
 > undefined reference to `std::__throw_out_of_range_fmt(char const*,
 > ...)'

 > It will also raise the following build failure on sparc/arc:

 > /home/autobuild/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld:
 > /home/autobuild/autobuild/instance-3/output-1/host/arceb-buildroot-linux-uclibc/sysroot/lib/libsupc++.a(eh_throw.o):
 > in function `__exchange_and_add_dispatch':
 > /SCRATCH/arcjenkins2/slaves/ru20-custom-arcgnu2/workspace/arcoss_verification/arc_gnu_toolchain_release/arc_gnu_toolchain_release/bd-uclibceb/gcc-stage2/arceb-snps-linux-uclibc/libstdc++-v3/include/ext/atomicity.h:82:
 > undefined reference to `__gnu_cxx::__exchange_and_add(int volatile*,
 > int)'
 > /home/autobuild/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld:
 > /SCRATCH/arcjenkins2/slaves/ru20-custom-arcgnu2/workspace/arcoss_verification/arc_gnu_toolchain_release/arc_gnu_toolchain_release/bd-uclibceb/gcc-stage2/arceb-snps-linux-uclibc/libstdc++-v3/include/ext/atomicity.h:82:
 > undefined reference to `__gnu_cxx::__exchange_and_add(int volatile*,
 > int)'

 > Instead of trying to patch the configure script as advocated by
 > Yann E. Morin, set LD to TARGET_CXX as:
 >  - this solution is quicker
 >  - usptream is dead (last release in 2016)
 >  - this solution has already been used in other packages (nodejs, zmqpp)

 > [1]: https://patchwork.ozlabs.org/project/buildroot/patch/20200812171821.2517-1-Evgeniy.Didin@synopsys.com/

 > Fixes:
 >  - http://autobuild.buildroot.org/results/6096c3ddc5edf3204635c2c90246c2e8c8e074e7
 >  - http://autobuild.buildroot.org/results/d8a/d8a3ab31c5b86871c7e1117f4ffa7b6cedfcb7e0/build-end.log

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot