From: Samuel Tardieu <sam@rfc1149.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Anton Kochkov <anton.kochkov@proton.me>,
qemu-arm@nongnu.org, Alexandre Iooss <erdnaxe@crans.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices
Date: Tue, 19 Dec 2023 20:13:52 +0100 [thread overview]
Message-ID: <87wmtaxaub.fsf@rfc1149.net> (raw)
In-Reply-To: <CAFEAcA8sTLZSQdqZmNGSv4yp3TZvq86kwbhU8gFmK2=j8vVZhQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
>> Any idea to why patchew fails to apply thoses patches? The mbox
>> at
>> <https://patchew.org/QEMU/20231216182740.3305724-1-sam@rfc1149.net/>
>> applies cleanly on master AFAICS.
>
> This is because you put a Based-on: tag in the cover letter.
> Based-on: means "please apply this other patch first before this
> series, because there is a dependency" (we use it for things
> like "this patchset has to sit on top of some other cleanup
> patchset I sent last week and which hasn't got into git yet").
> So patchew applied Anton's original patch from 2022, and then
> tried
> to apply your three patches on top of that, which caused a
> conflict.
Thanks for the explanation. I thought "Based-on:" was just a
polite way of attributing credit to past discussions. I'll keep
that in mind. Do you want me to resubmit it as a v2 without the
"Based-on:" tag so that patchew gets it right?
> Anyway, I just wanted to say that this patchset is on my
> todo list to review but I'm not going to be able to get to
> it before I break for Christmas, so I'll get back to it
> in January. Thanks for the contribution!
Noted!
Best.
Sam
--
Samuel Tardieu
next prev parent reply other threads:[~2023-12-19 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 18:27 [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices Samuel Tardieu
2023-12-16 18:27 ` [PATCH 1/3] hw/intc/armv7m_nvic: add "num-prio-bits" property Samuel Tardieu
2023-12-16 18:27 ` [PATCH 2/3] hw/arm/armv7m: alias the NVIC " Samuel Tardieu
2023-12-16 18:27 ` [PATCH 3/3] hw/arm/socs: configure priority bits for existing SOCs Samuel Tardieu
2023-12-17 7:35 ` [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices Samuel Tardieu
2023-12-19 16:05 ` Peter Maydell
2023-12-19 19:13 ` Samuel Tardieu [this message]
2023-12-19 20:46 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmtaxaub.fsf@rfc1149.net \
--to=sam@rfc1149.net \
--cc=alistair@alistair23.me \
--cc=anton.kochkov@proton.me \
--cc=erdnaxe@crans.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.