From: "Bjørn Mork" <bjorn@mork.no>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Grant Grundler <grundler@chromium.org>,
Hayes Wang <hayeswang@realtek.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, Brian Geffon <bgeffon@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] usb: core: Allow subclassed USB drivers to override usb_choose_configuration()
Date: Sat, 02 Dec 2023 20:11:17 +0100 [thread overview]
Message-ID: <87wmtw2ze2.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20231201102946.v2.2.Iade5fa31997f1a0ca3e1dec0591633b02471df12@changeid> (Douglas Anderson's message of "Fri, 1 Dec 2023 10:29:51 -0800")
Douglas Anderson <dianders@chromium.org> writes:
> The r8152 driver tried to make things work by implementing a USB
> generic_subclass driver and then overriding the normal config
> selection after it happened. This is less than ideal and also caused
> breakage if someone deauthorized and re-authorized the USB device
> because the USB core ended up going back to it's default logic for
> choosing the best config. I made an attempt to fix this [1] but it was
> a bit ugly.
>
> Let's do this better and allow USB generic_subclass drivers to
> override usb_choose_configuration().
>
> [1] https://lore.kernel.org/r/20231130154337.1.Ie00e07f07f87149c9ce0b27ae4e26991d307e14b@changeid
>
> Suggested-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Brilliant! Thanks for doing this. It is obviously what I should have
done in the first place if I had been smart enough.
Bjørn
next prev parent reply other threads:[~2023-12-02 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 18:29 [PATCH v2 0/3] net: usb: r8152: Fix lost config across deauthorize+authorize Douglas Anderson
2023-12-01 18:29 ` [PATCH v2 1/3] usb: core: Don't force USB generic_subclass drivers to define probe() Douglas Anderson
2023-12-01 19:28 ` Alan Stern
2023-12-02 2:14 ` Grant Grundler
2023-12-01 18:29 ` [PATCH v2 2/3] usb: core: Allow subclassed USB drivers to override usb_choose_configuration() Douglas Anderson
2023-12-01 19:30 ` Alan Stern
2023-12-02 19:11 ` Bjørn Mork [this message]
2023-12-01 18:29 ` [PATCH net v2 3/3] r8152: Choose our USB config with choose_configuration() rather than probe() Douglas Anderson
2023-12-02 6:28 ` Grant Grundler
2023-12-05 2:27 ` Jakub Kicinski
2023-12-05 2:27 ` [PATCH v2 0/3] net: usb: r8152: Fix lost config across deauthorize+authorize Jakub Kicinski
2023-12-05 2:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmtw2ze2.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=bgeffon@google.com \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.