All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Marc Zyngier <maz@kernel.org>
Cc: "Maulik Shah (mkshah)" <quic_mkshah@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v4 1/2] irqchip/qcom-pdc: Add support for v3.2 HW
Date: Mon, 02 Oct 2023 14:59:14 +0200	[thread overview]
Message-ID: <87wmw5ch99.ffs@tglx> (raw)
In-Reply-To: <20230905-topic-sm8x50-upstream-pdc-ver-v4-1-fc633c7df84b@linaro.org>

On Tue, Sep 05 2023 at 15:19, Neil Armstrong wrote:
> Starting from HW version 3.2 the IRQ_ENABLE bit has moved to the
> IRQ_i_CFG register and requires a change of the driver to avoid
> writing into an undefined register address.
>
> Get the HW version from registers and set the IRQ_ENABLE bit to the
> correct register depending on the HW version.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Maulik Shah <quic_mkshah@quicinc.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

This S-O-B chain is broken. Who is the real author of that?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Thanks,

        tglx



  parent reply	other threads:[~2023-10-02 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 13:19 [PATCH v4 0/2] irqchip/qcom-pdc: support v3.2 HW Neil Armstrong
2023-09-05 13:19 ` [PATCH v4 1/2] irqchip/qcom-pdc: Add support for " Neil Armstrong
2023-09-06 16:55   ` Konrad Dybcio
2023-09-07  7:57     ` Neil Armstrong
2023-09-12 12:49   ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Neil Armstrong
2023-10-02 12:59   ` Thomas Gleixner [this message]
2023-10-02 13:16     ` [PATCH v4 1/2] " Neil Armstrong
2023-09-05 13:19 ` [PATCH v4 2/2] arm64: dts: qcom: sm8150: extend the size of the PDC resource neil.armstrong
2023-09-12 12:49   ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmw5ch99.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_mkshah@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.