From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 836AAE6FE2F for ; Fri, 22 Sep 2023 14:00:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjghW-0006qd-Gz; Fri, 22 Sep 2023 10:00:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjghV-0006qG-7x for qemu-devel@nongnu.org; Fri, 22 Sep 2023 10:00:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjghR-0005qP-W9 for qemu-devel@nongnu.org; Fri, 22 Sep 2023 10:00:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695391198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8+D1RE33DKPVBC0jFZ1pXRWmz6S/+yl8DY6ABWfjglA=; b=BB9YrhLdYbQUCjWopIZ+cPfFRnLszUeqQETl6+mKvUpI7vXI+GV3JPt6d3nq/Uoy3sK2jo 4qnJPEjEXVzoeM5nWRHfVsit7btsE3VeHeK9WzB504OpX1n/Ne3PWWADiODl3/RKyeiVF8 ZcCWzr02xtPh2IkibEBIf0Ccoo0W+ZI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-83-wwqwdAEIO4ynR5cf6uV2kg-1; Fri, 22 Sep 2023 09:59:56 -0400 X-MC-Unique: wwqwdAEIO4ynR5cf6uV2kg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42E84280AA22; Fri, 22 Sep 2023 13:59:56 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20C02492C37; Fri, 22 Sep 2023 13:59:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1554921E6900; Fri, 22 Sep 2023 15:59:55 +0200 (CEST) From: Markus Armbruster To: Kevin Wolf Cc: qemu-devel@nongnu.org, berrange@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH 09/11] hw/rx/rx62n: Use qdev_prop_set_array() References: <20230908143703.172758-1-kwolf@redhat.com> <20230908143703.172758-10-kwolf@redhat.com> Date: Fri, 22 Sep 2023 15:59:55 +0200 In-Reply-To: <20230908143703.172758-10-kwolf@redhat.com> (Kevin Wolf's message of "Fri, 8 Sep 2023 16:37:00 +0200") Message-ID: <87wmwis3z8.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Kevin Wolf writes: > Instead of manually setting "foo-len" and "foo[i]" properties, build a > QList and use the new qdev_prop_set_array() helper to set the whole > array property with a single call. > > Signed-off-by: Kevin Wolf > --- > hw/rx/rx62n.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/hw/rx/rx62n.c b/hw/rx/rx62n.c > index 3e887a0fc7..6990096642 100644 > --- a/hw/rx/rx62n.c > +++ b/hw/rx/rx62n.c > @@ -28,6 +28,7 @@ > #include "hw/sysbus.h" > #include "hw/qdev-properties.h" > #include "sysemu/sysemu.h" > +#include "qapi/qmp/qlist.h" > #include "qom/object.h" >=20=20 > /* > @@ -130,22 +131,22 @@ static void register_icu(RX62NState *s) > { > int i; > SysBusDevice *icu; > + QList *ipr_map, *trigger_level; >=20=20 > object_initialize_child(OBJECT(s), "icu", &s->icu, TYPE_RX_ICU); > icu =3D SYS_BUS_DEVICE(&s->icu); > - qdev_prop_set_uint32(DEVICE(icu), "len-ipr-map", NR_IRQS); > + > + ipr_map =3D qlist_new(); > for (i =3D 0; i < NR_IRQS; i++) { > - char propname[32]; > - snprintf(propname, sizeof(propname), "ipr-map[%d]", i); > - qdev_prop_set_uint32(DEVICE(icu), propname, ipr_table[i]); > + qlist_append_int(ipr_map, ipr_table[i]); > } > - qdev_prop_set_uint32(DEVICE(icu), "len-trigger-level", > - ARRAY_SIZE(levelirq)); > + qdev_prop_set_array(sysctl, "ipr-map", ipr_map); ../hw/rx/rx62n.c:143:25: error: =E2=80=98sysctl=E2=80=99 undeclared (first = use in this function); did you mean =E2=80=98syscall=E2=80=99? Should be DEVICE(icu), I guess. > + > + trigger_level =3D qlist_new(); > for (i =3D 0; i < ARRAY_SIZE(levelirq); i++) { > - char propname[32]; > - snprintf(propname, sizeof(propname), "trigger-level[%d]", i); > - qdev_prop_set_uint32(DEVICE(icu), propname, levelirq[i]); > + qlist_append_int(trigger_level, levelirq[i]); > } > + qdev_prop_set_array(sysctl, "trigger-level", trigger_level); Again. >=20=20 > for (i =3D 0; i < NR_IRQS; i++) { > s->irq[i] =3D qdev_get_gpio_in(DEVICE(icu), i);