Re: [Intel-xe] [PATCH 00/10] Add OA functionality to Xe

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 01 Sep 2023 00:55:58 -0700, Landwerlin, Lionel G wrote:
>

Hi Lionel,

>
> I just noticed this change in the uAPI :
>
> @@ -298,6 +305,7 @@  struct drm_xe_query_gts {
>		__u64 native_mem_regions;	/* bit mask of instances from drm_xe_query_mem_usage */
>		__u64 slow_mem_regions;		/* bit mask of instances from drm_xe_query_mem_usage */
>		__u64 inaccessible_mem_regions;	/* bit mask of instances from drm_xe_query_mem_usage */
> +		__u64 oa_timestamp_freq;
>		__u64 reserved[8];
>	} gts[];
>  };
>
> I think you need to remove one item from the reserved field so that the structure size doesn't change.

Thanks, done here:

https://patchwork.freedesktop.org/series/121084/#rev5

Though this sort of stuff might move into the OA info query in the future.

Thanks.
--
Ashutosh