From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Timlee <timlee@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw89: fix a width vs precision bug
Date: Mon, 21 Aug 2023 19:05:55 +0300 [thread overview]
Message-ID: <87wmxoidng.fsf@kernel.org> (raw)
In-Reply-To: <63f8219b49604fc9805319c391ee44bf@realtek.com> (Ping-Ke Shih's message of "Tue, 8 Aug 2023 08:30:35 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: Dan Carpenter <dan.carpenter@linaro.org>
>> Sent: Tuesday, August 8, 2023 1:36 PM
>> To: Timlee <timlee@realtek.com>
>> Cc: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo
>> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
>> kernel-janitors@vger.kernel.org
>> Subject: [PATCH] wifi: rtw89: fix a width vs precision bug
>>
>> The "buf" is skb->data that comes from the firmware. We want to print
>> "len" number of bytes. But there is a missing period so the "len"
>> variable is used for formatting (width) instead of limiting the output
>> (precision).
>>
>> Fixes: cad2bd8a136c ("wifi: rtw89: support firmware log with formatted text")
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> Thanks for the fix.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Weird, Ping's reply didn't go to patchwork:
https://patchwork.kernel.org/project/linux-wireless/patch/0700c7b9-bfd3-4aa6-82bf-5bf3c74644e1@moroto.mountain/
But I do see it on the list:
https://lore.kernel.org/all/63f8219b49604fc9805319c391ee44bf@realtek.com/
Crossing fingers that this was just a random anomaly in patchwork and
it's not losing more email.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-08-21 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 5:36 [PATCH] wifi: rtw89: fix a width vs precision bug Dan Carpenter
2023-08-08 8:30 ` Ping-Ke Shih
2023-08-21 16:05 ` Kalle Valo [this message]
2023-08-21 16:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmxoidng.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=timlee@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.