All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Tobias Klausmann <tobias.klausmann@freenet.de>,
	Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
	netdev@vger.kernel.org
Subject: Re: r8169: transmit transmit queue timed out - v6.4 cycle
Date: Fri, 14 Jul 2023 09:16:00 +0200	[thread overview]
Message-ID: <87wmz3ezf3.fsf@kurt> (raw)
In-Reply-To: <04dc4bbb-6bfd-4074-6d32-007dc8d213e5@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4522 bytes --]

On Thu Jul 13 2023, Heiner Kallweit wrote:
> On 13.07.2023 09:01, Kurt Kanzenbach wrote:
>> Hello Heiner,
>> 
>> On Mon Jul 10 2023, Heiner Kallweit wrote:
>>> On 05.07.2023 00:25, Tobias Klausmann wrote:
>>>> Hi, top posting as well, as im on vacation, too. The system does not
>>>> allow disabling ASPM, it is a very constrained notebook BIOS, thus
>>>> the suggestion is nit feasible. All in all the sugesstion seems not
>>>> favorable for me, as it is unknown how many systems are broken the
>>>> same way. Having a workaround adviced as default seems oretty wrong
>>>> to me.
>>>>
>>>
>>> To get a better understanding of the affected system:
>>> Could you please provide a full dmesg log and the lspci -vv output?
>> 
>> I'm having the same problem as described by Tobias on a desktop
>> machine. v6.3 works; v6.4 results in transmit queue timeouts
>> occasionally. Reverting 2ab19de62d67 ("r8169: remove ASPM restrictions
>> now that ASPM is disabled during NAPI poll") "solves" the issue.
>> 
>> From dmesg:
>> 
>> |~ % dmesg | grep -i ASPM
>> |[    0.152746] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it
>> |[    0.905100] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3]
>> |[    0.906508] acpi PNP0A08:00: FADT indicates ASPM is unsupported, using BIOS configuration
>> |[    1.156585] pci 10000:e1:00.0: can't override BIOS ASPM; OS doesn't have ASPM control
>> |[    1.300059] r8169 0000:03:00.0: can't disable ASPM; OS doesn't have ASPM control
>> 
>> In addition, with commit 2ab19de62d67 in kernel regular messages like
>> this show up:
>> 
>> |[ 7487.214593] pcieport 0000:00:1c.2: AER: Corrected error received: 0000:03:00.0
>> 
>> I'm happy to test any patches or provide more info if needed.
>> 
> Thanks for the report. It's interesting that the issue seems to occur only on systems
> where BIOS doesn't allow OS to control ASPM. Maybe this results in the PCI subsystem
> not properly initializing something.
> Kurt/Klaus: Could you please boot with cmd line parameter pcie_aspm=force and see
> whether this changes something?
> This parameter lets Linux ignore the BIOS setting. You should see a message
> "PCIe ASPM is forcibly enabled" in the dmesg log with this parameter.

Seems like this does not help. There are still PCIe errors:

|~ # dmesg | grep -i ASPM
|[    0.000000] Command line: BOOT_IMAGE=/vmlinuz-6.4.2-gentoo-kurtOS root=/dev/nvme0n1p3 ro kvm-intel.nested=1 vga=794 pcie_aspm=force
|[    0.044016] Kernel command line: BOOT_IMAGE=/vmlinuz-6.4.2-gentoo-kurtOS root=/dev/nvme0n1p3 ro kvm-intel.nested=1 vga=794 pcie_aspm=force
|[    0.044048] PCIe ASPM is forcibly enabled
|[    0.153011] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it
|[    0.916341] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3]
|[    0.917719] acpi PNP0A08:00: FADT indicates ASPM is unsupported, using BIOS configuration
|~ # dmesg | grep -i r8169
|[    1.337417] r8169 0000:03:00.0 eth0: RTL8168h/8111h, 6c:3c:8c:2c:bd:de, XID 541, IRQ 164
|[    1.337422] r8169 0000:03:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko]
|[    2.833876] r8169 0000:03:00.0 enp3s0: renamed from eth0
|[   20.886564] Generic FE-GE Realtek PHY r8169-0-300:00: attached PHY driver (mii_bus:phy_addr=r8169-0-300:00, irq=MAC)
|[   21.168373] r8169 0000:03:00.0 enp3s0: Link is Down
|[   24.006543] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow control off
|~ # dmesg | tail
|[   20.886564] Generic FE-GE Realtek PHY r8169-0-300:00: attached PHY driver (mii_bus:phy_addr=r8169-0-300:00, irq=MAC)
|[   21.168373] r8169 0000:03:00.0 enp3s0: Link is Down
|[   24.006543] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow control off
|[   24.006568] IPv6: ADDRCONF(NETDEV_CHANGE): enp3s0: link becomes ready
|[   24.567803] ACPI Warning: \_SB.PC00.PEG1.PEGP._DSM: Argument #4 type mismatch - Found [Buffer], ACPI requires [Package] (20230331/nsarguments-61)
|[   41.563396] pcieport 0000:00:1c.2: AER: Corrected error received: 0000:03:00.0
|[   47.065441] pcieport 0000:00:1c.2: AER: Multiple Corrected error received: 0000:03:00.0
|[   54.264285] pcieport 0000:00:1c.2: AER: Corrected error received: 0000:03:00.0
|[   54.424210] pcieport 0000:00:1c.2: AER: Corrected error received: 0000:03:00.0
|[   55.443439] pcieport 0000:00:1c.2: AER: Corrected error received: 0000:03:00.0

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2023-07-14  7:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 13:46 r8169: transmit transmit queue timed out - v6.4 cycle Tobias Klausmann
2023-06-22 14:14 ` Bagas Sanjaya
2023-07-25 11:17   ` Linux regression tracking #update (Thorsten Leemhuis)
     [not found] ` <CAFSsGVtiXSK_0M_TQm_38LabiRX7E5vR26x=cKags4ZQBqfXPQ@mail.gmail.com>
2023-06-23 17:30   ` Tobias Klausmann
2023-07-04 17:42     ` Linux regression tracking (Thorsten Leemhuis)
2023-07-10 11:24       ` Linux regression tracking (Thorsten Leemhuis)
     [not found]       ` <CAFSsGVuDLnW_7iwSUNebx8Lku3CGZhcym3uXfMFnotA=OYJJjQ@mail.gmail.com>
     [not found]         ` <A69A7D66-A73A-4C4D-913B-8C2D4CF03CE2@freenet.de>
2023-07-10 11:39           ` Heiner Kallweit
2023-07-12 14:33             ` Tobias Klausmann
2023-07-13  7:01             ` Kurt Kanzenbach
2023-07-13 15:59               ` Heiner Kallweit
2023-07-14  7:16                 ` Kurt Kanzenbach [this message]
2023-07-14  7:42                   ` Heiner Kallweit
2023-07-14  8:09                     ` Kurt Kanzenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmz3ezf3.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=regressions@lists.linux.dev \
    --cc=tobias.klausmann@freenet.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.