From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE6CC001B1 for ; Wed, 5 Jul 2023 08:35:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbjGEIfc (ORCPT ); Wed, 5 Jul 2023 04:35:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229752AbjGEIfb (ORCPT ); Wed, 5 Jul 2023 04:35:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52F37171D for ; Wed, 5 Jul 2023 01:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688546081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MUOdZ4jqa/jKVAp7tf5tIQFJQKaJ8W9OX/5MST4+nx0=; b=GzGNi5X8hrmphoYvoPFwu75joMBk84Dxvn5gRjoqWpGVk/LSF9xQtdGdadQHFhvYj5bXo8 R+BHdY+EXzo3DQa81+qbT3Lt2Z/AKYLEskIau605/biur2QAMHaBxOy3cfuZePwLiTG5Ay 60khFggyQ5DMTyTe0VltkhFMmvhwKEg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-_t9WVPGVNqqeQfOZc4adJQ-1; Wed, 05 Jul 2023 04:34:38 -0400 X-MC-Unique: _t9WVPGVNqqeQfOZc4adJQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fb9c4b7020so5473658e87.0 for ; Wed, 05 Jul 2023 01:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688546077; x=1691138077; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MUOdZ4jqa/jKVAp7tf5tIQFJQKaJ8W9OX/5MST4+nx0=; b=fhrjq3Y8fqltAGqOhBkD/WCqZwYLDzag1yi1eeOtkCoFublJjmWUV1VjwugGIwkFwX LMg1FG1CvWEHUKJtNwXNJW5Nnbb1VK7EKIrgeBua29R2CFl4DAx1wiPkQnLboQkTCXGM 1lFCIXXxfeEg0LqLF5VKDvgLL5/HWo0u3yL0eGDZ/dTWLCqnAUvKHAbkbPVKu7MKXLo6 Wkl1P2dXRNTolT+prTXZ+Mgjrx71nma6kewu/V/eUwUfUHFdkVBeWIxyOXBBXYwUk1MZ fSSpoqAhv60tl+IHEG6Vz3QS4WH0bNgFeIwXVQdfO6MvHHkCAy4GoF4A4oHyKr9zcRH/ 1cJw== X-Gm-Message-State: ABy/qLYWAyN5T+rpbH5kFhwIxKZVsHtViNepsbrnsLnki0W5Do4AWOxH hCWFcZ7iM9NjbW5F2oEPJSLXAbIeSQzyUw/geN+oeDNx8PbYSnMd/oauYg60xKYC90onN25lKro XD9iYjbJnJCrCicMPaRXyauM= X-Received: by 2002:a19:5012:0:b0:4f9:567a:7a59 with SMTP id e18-20020a195012000000b004f9567a7a59mr12555430lfb.30.1688546076852; Wed, 05 Jul 2023 01:34:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlExsFBiiX6bb3J4q5RqDUoq+KcMvZbY+mbCkL7JfUUF8owQK16V9ABMtujWwpj0RBMM4IyVjA== X-Received: by 2002:a19:5012:0:b0:4f9:567a:7a59 with SMTP id e18-20020a195012000000b004f9567a7a59mr12555416lfb.30.1688546076566; Wed, 05 Jul 2023 01:34:36 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id a15-20020adffacf000000b0031434c08bb7sm8537215wrs.105.2023.07.05.01.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 01:34:36 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Thierry Reding , Mikko Perttunen Subject: Re: [PATCH 04/10] drm/tegra: Set fbdev flags In-Reply-To: <20230704160133.20261-5-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-5-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 10:34:35 +0200 Message-ID: <87wmzerc2s.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Thomas Zimmermann writes: > Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with > FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should > be accessed with the CPU's regular memory ops. > > Signed-off-by: Thomas Zimmermann > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c > index 82577b7c88da..8074430c52f1 100644 > --- a/drivers/gpu/drm/tegra/fbdev.c > +++ b/drivers/gpu/drm/tegra/fbdev.c > @@ -103,6 +103,8 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, > return PTR_ERR(info); > } > > + info->flags = FBINFO_DEFAULT; > + > fb = tegra_fb_alloc(drm, &cmd, &bo, 1); > if (IS_ERR(fb)) { > err = PTR_ERR(fb); > @@ -132,6 +134,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, > } > } > > + info->flags |= FBINFO_VIRTFB; I see that all fbdev drivers just do: info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB Guess you are doing in two assignments to be consistent with drm_fbdev_dma.c ? I was just curious about the rationale for setting the flags in two steps. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EC5AEB64DA for ; Wed, 5 Jul 2023 08:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQw4pd8byzufW2Ux4FbRA+SmI9+CUNq61gc1hv3y7SU=; b=1Y1qMTO50kLQP6 kx5UA5uSWXgwQRryaI9WelHrsmXfBgfhfX90ZDRqWHiFQ57DrssoY1NFGPc1qQGywqAtXz9hJdAsI 6qfigkWhrRI8hDxV2AGI+FTdDlJ1P38EqW/HuoKrquU2RoAFjcg0sHJrADvsvqxEXL/9keYDxBLuR WTQfzZzjKqjujEN8V37YMKftwLD4gvfLwfEEwmihV8UcsMWFaFyxB1H+MkOZstPDDP7CH7fiuqCBS oYbOjhs+Ve0tVVXY/RfB4enBhMkwNyBUrf+Im/szdu20wUNyNzRPCgJp7adqXy6euacddyMjeptwC /ODGrZSMLqeGBE6lwr/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGxyF-00FERF-1b; Wed, 05 Jul 2023 08:34:43 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGxyC-00FEQX-23 for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 08:34:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688546079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MUOdZ4jqa/jKVAp7tf5tIQFJQKaJ8W9OX/5MST4+nx0=; b=BQX4OAWtrKI5e6KEIyYQ00IlnS+cFEsRD+YyGnQJSuKGE/a0mfMyKmblqPXFhJvrAdiAWx nbLnv7V5wt9iD9AVeBFlOoAu0Vc5qYfLda0hOMx4cK+BJOrEqCZM6TD8unluy3rPkeoWxi 5SMk1/OVEPLmYWbQrjn8mcPcyLCydao= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-HfqCy1dcOAupBmwa7pO0RQ-1; Wed, 05 Jul 2023 04:34:38 -0400 X-MC-Unique: HfqCy1dcOAupBmwa7pO0RQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4fb9c4b7020so5473659e87.0 for ; Wed, 05 Jul 2023 01:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688546077; x=1691138077; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MUOdZ4jqa/jKVAp7tf5tIQFJQKaJ8W9OX/5MST4+nx0=; b=XUCPcc0ELTJbKh2y6i59HDpWHbTexSoei778vWkRyl+VABgUowWYpOenZiIo3F2Z9r +LlilfvQka0S86/Rl/5WtmOjQzS4R9w8dtiLxUBRUk/ITGe78tmaIGd1Xpj5UIF9VQ3N +oTByqqRqlliMb/XdSsWt88fzIFhk5wTMiXWZAL5qF4IGfE0MVebnEYkHT9m1qj7iK5A MihCOPrkSUEigEXGHzIe8zOwohqyNCSFbQGlCCBFlYUpwEZicQpAbuA9W+hoQinfckN1 lEIef2iMW26fs9VIqtC2Mv5AxgF4RptEqfQdwaz+1PjTiHjHn44S3KePkqgZQPdHev48 4DkQ== X-Gm-Message-State: ABy/qLbo5FUbDcU4WxZuO5jS97LL2rbuZOXRgnO1SFfv8sYClLEiVRZG /ZRwtEYrIhd8xJTk7mrhVTv7ptHFfAzKL/mvmT+TjuzRaf0SkBK8MWqbdNyViQF54CCf2REcGQ5 izXuqaJTkocv90cGCJPeblCZMaLyuWz22QWI= X-Received: by 2002:a19:5012:0:b0:4f9:567a:7a59 with SMTP id e18-20020a195012000000b004f9567a7a59mr12555436lfb.30.1688546076853; Wed, 05 Jul 2023 01:34:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlExsFBiiX6bb3J4q5RqDUoq+KcMvZbY+mbCkL7JfUUF8owQK16V9ABMtujWwpj0RBMM4IyVjA== X-Received: by 2002:a19:5012:0:b0:4f9:567a:7a59 with SMTP id e18-20020a195012000000b004f9567a7a59mr12555416lfb.30.1688546076566; Wed, 05 Jul 2023 01:34:36 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id a15-20020adffacf000000b0031434c08bb7sm8537215wrs.105.2023.07.05.01.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 01:34:36 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Thierry Reding , Mikko Perttunen Subject: Re: [PATCH 04/10] drm/tegra: Set fbdev flags In-Reply-To: <20230704160133.20261-5-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-5-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 10:34:35 +0200 Message-ID: <87wmzerc2s.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_013440_740741_C27D5F41 X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: > Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with > FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should > be accessed with the CPU's regular memory ops. > > Signed-off-by: Thomas Zimmermann > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c > index 82577b7c88da..8074430c52f1 100644 > --- a/drivers/gpu/drm/tegra/fbdev.c > +++ b/drivers/gpu/drm/tegra/fbdev.c > @@ -103,6 +103,8 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, > return PTR_ERR(info); > } > > + info->flags = FBINFO_DEFAULT; > + > fb = tegra_fb_alloc(drm, &cmd, &bo, 1); > if (IS_ERR(fb)) { > err = PTR_ERR(fb); > @@ -132,6 +134,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, > } > } > > + info->flags |= FBINFO_VIRTFB; I see that all fbdev drivers just do: info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB Guess you are doing in two assignments to be consistent with drm_fbdev_dma.c ? I was just curious about the rationale for setting the flags in two steps. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C7DFEB64DA for ; Wed, 5 Jul 2023 08:34:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06B4810E33A; Wed, 5 Jul 2023 08:34:42 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3574B10E33A for ; Wed, 5 Jul 2023 08:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688546080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MUOdZ4jqa/jKVAp7tf5tIQFJQKaJ8W9OX/5MST4+nx0=; b=WMq01wB/n4y/LeGf/yxaEOBLJrUnqIDRduv6wturpL0HDoMZLinl8MvgNYYhGBzxHgletn 1vvNtY3eEqFQ0E7KgJWN9Y2c+A0CvEYVzHQ5vo3T2jERZHpX3sWvg5QgfPoPaxF1ygKBGy hHfXaXbkn3i3uo70AfGgOq8zdpDKa+s= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-rU1rr9QZP5mUt6aR3eBHyw-1; Wed, 05 Jul 2023 04:34:39 -0400 X-MC-Unique: rU1rr9QZP5mUt6aR3eBHyw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fb9c4b7020so5473680e87.0 for ; Wed, 05 Jul 2023 01:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688546077; x=1691138077; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MUOdZ4jqa/jKVAp7tf5tIQFJQKaJ8W9OX/5MST4+nx0=; b=Jcz4UmZYEG4cpKE+Lc8b5IRDTVaOUwkRZF/WneX6ihuZA4gwjLRDb5FFFlvimE/a5P SkO+c0/XLZH6/XTWBg9SEtZ1CKIqALpXoNTnVshuydbZxl+v5F6imVQZee10iwulURQ4 evz58q0evMa1yeFWGS3v7TFUUrC1rrQeld2rgQT36k5/6L/ZAq7m/nVutEwzmxMJvy4U usAXDYUep9gPYAoT5/Y8JNZCFmXyGYGxI3HBZ6XbWuDh9jpdOpl1G8+Ib9xFaOyJfDUq rvssfbZ9Jk+CZ0QhnHi0seQvvUVWF6OPlUyX9wBgG9T7cj08c5gOvOsU3orMWJXvLJjq 30gQ== X-Gm-Message-State: ABy/qLadeqji8XjdWJZ5IsQki0JhGYtknSCl6B6LLB9A5sRhA4hZpTy2 gobDBWchg2mJAsfNG655/YMrb7lR4R+GzM0iU18QWn68eXwzTjNX2n39Penf0f95Styy1XIjQQy OutMxsj1YZ/KzCa3NwAHd+A9c1ptg+EtzsTb9 X-Received: by 2002:a19:5012:0:b0:4f9:567a:7a59 with SMTP id e18-20020a195012000000b004f9567a7a59mr12555435lfb.30.1688546076853; Wed, 05 Jul 2023 01:34:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlExsFBiiX6bb3J4q5RqDUoq+KcMvZbY+mbCkL7JfUUF8owQK16V9ABMtujWwpj0RBMM4IyVjA== X-Received: by 2002:a19:5012:0:b0:4f9:567a:7a59 with SMTP id e18-20020a195012000000b004f9567a7a59mr12555416lfb.30.1688546076566; Wed, 05 Jul 2023 01:34:36 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id a15-20020adffacf000000b0031434c08bb7sm8537215wrs.105.2023.07.05.01.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 01:34:36 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Subject: Re: [PATCH 04/10] drm/tegra: Set fbdev flags In-Reply-To: <20230704160133.20261-5-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-5-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 10:34:35 +0200 Message-ID: <87wmzerc2s.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , Thierry Reding , Thomas Zimmermann , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thomas Zimmermann writes: > Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with > FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should > be accessed with the CPU's regular memory ops. > > Signed-off-by: Thomas Zimmermann > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c > index 82577b7c88da..8074430c52f1 100644 > --- a/drivers/gpu/drm/tegra/fbdev.c > +++ b/drivers/gpu/drm/tegra/fbdev.c > @@ -103,6 +103,8 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, > return PTR_ERR(info); > } > > + info->flags = FBINFO_DEFAULT; > + > fb = tegra_fb_alloc(drm, &cmd, &bo, 1); > if (IS_ERR(fb)) { > err = PTR_ERR(fb); > @@ -132,6 +134,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, > } > } > > + info->flags |= FBINFO_VIRTFB; I see that all fbdev drivers just do: info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB Guess you are doing in two assignments to be consistent with drm_fbdev_dma.c ? I was just curious about the rationale for setting the flags in two steps. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat